Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup semantic-release #247

Merged
merged 3 commits into from Jan 9, 2020
Merged

Setup semantic-release #247

merged 3 commits into from Jan 9, 2020

Conversation

limonte
Copy link
Contributor

@limonte limonte commented Jan 8, 2020

Closes our emotional discussion in #242 (comment) :)

You're already using Angular Commit Message Conventions for this repo, so setting up semantic-release is simple, read more: https://github.com/semantic-release/semantic-release/

In order to publish to GitHub, add GH_TOKEN or GITHUB_TOKEN env variable in Travis config, read more: https://github.com/semantic-release/github/#environment-variables

In order to publish to npm, add NPM_TOKEN env variable in Travis config, read more: https://github.com/semantic-release/npm#environment-variables

That should be it.

@limonte limonte changed the title Setup semantic-release [WIP] Setup semantic-release Jan 8, 2020
@limonte
Copy link
Contributor Author

limonte commented Jan 8, 2020

One detail to finish here, the after_success task should run only once. Currently, it's being triggered for every node_js version.

Resolved.

@limonte limonte changed the title [WIP] Setup semantic-release Setup semantic-release Jan 8, 2020
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's give this a try. If it works well we can use it on other karma-runner/*

@johnjbarton johnjbarton merged commit 9b6e5f8 into karma-runner:master Jan 9, 2020
@limonte
Copy link
Contributor Author

limonte commented Jan 9, 2020

Thanks! Let's give this a try. If it works well we can use it on other karma-runner/*

You're welcome! Sure, you can apply the same config for other repos. As you can see, the configuration is quite simple.

@limonte
Copy link
Contributor Author

limonte commented Jan 9, 2020

The releasing process failed because env variables aren't set, add GH_TOKEN and NPM_TOKEN to Travis and re-run the build, then the releasing magic should happen.

@johnjbarton
Copy link
Contributor

Like #249 ?

@limonte
Copy link
Contributor Author

limonte commented Jan 9, 2020

Like #249 ?

No. You just exposed your sensitive data, you need to delete those tokens ASAP! Otherwise, someone will use them for evil purposes.

@limonte
Copy link
Contributor Author

limonte commented Jan 9, 2020

@johnjbarton
Copy link
Contributor

Thanks, but our travis acct has no repo settings. I'll have to dig in to that.

@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@johnjbarton
Copy link
Contributor

ok eventually I got all the things to work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants