Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern ".../node_modules/karma-jasmine/lib/adapter.js" does not match any file. #242

Closed
limonte opened this issue Jan 4, 2020 · 12 comments

Comments

@limonte
Copy link
Contributor

limonte commented Jan 4, 2020

In v3.0.0 release you probably forgot to build before the release, the same as in #123 (comment)

@limonte
Copy link
Contributor Author

limonte commented Jan 4, 2020

How many times this issue needs to be reported before you guys realize that manual work is a bug and the releasing process should be automated with semantic-release or any similar tool? :)

@coyoteecd
Copy link

Same here, lib/adapter.js file is missing from the 3.0.0 release...

@pmstss
Copy link

pmstss commented Jan 5, 2020

Having the same in output with 3.0.0:

05 01 2020 13:03:34.145:WARN [filelist]: Pattern "./node_modules/karma-jasmine/lib/adapter.js" does not match any file.

Is it the reason of getting You need to include some adapter that implements __karma__.start method! (works with 2.0.1)?

@wodddy
Copy link

wodddy commented Jan 6, 2020

almost 4 years ago it was just like this
#123 (comment)

@fr0
Copy link

fr0 commented Jan 6, 2020

What is the workaround for this?

@johnjbarton
Copy link
Contributor

Please reinstall, that should bring in 3.0.1.

@DamienCassou
Copy link

Please reinstall, that should bring in 3.0.1.

thank you very much!

@limonte: when I see a sentence like the one you wrote above, I feel bad for the maintainer who is doing his/her best to provide a tool we all use. In your message I read both a piece of advice (which is good) and some critics on how the maintainer is working. I think such maintainer doesn't deserve being told s/he can't do the job properly. May I suggest you spend some more time writing this kind of messages to make sure the reader is going to appreciate the advice instead of feeling criticized?

@limonte
Copy link
Contributor Author

limonte commented Jan 8, 2020

@DamienCassou

Thank you for the advice, I'm fine with being honest and not losing time for imagining what emotions people might have.

I do criticize maintainers for repeating the same mistake for almost 4 years and not trying to solve it. That's unprofessionally and I will tell that directly. Now, it's on them either to fix the issue or to get offended and continue doing the same mistakes.

I have an advice to you as well, stop imagining what other people might feel :) There's the exemplary case on GitHub demonstrating what might happen if you care about feelings too much: microsoft/vscode#87268

Because of feelings, the VSCode's issue tracker was put down for a couple of days. Caring about feelings is often counterproductive.

Man up, brother, and nothing in this world will be able to make you feel bad.

All the best to you in 2020!

@johnjbarton
Copy link
Contributor

@limonte You seem to be quite the expert. Your pull request would be the professional response to a problem that bothers you.

@simonua
Copy link

simonua commented Jan 8, 2020

@johnjbarton, that was the best possible response. Well done. Also, thank you very much for maintaining this package. I appreciate you.

@limonte
Copy link
Contributor Author

limonte commented Jan 8, 2020

@limonte You seem to be quite the expert. Your pull request would be the professional response to a problem that bothers you.

I'm not the expert by any means, but here you go: #247

@johnjbarton
Copy link
Contributor

PR #247 (eventually) lead to our use of semantic release, something I hope to rollout to the rest of the karma-runner projects. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants