Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies #193

Merged
merged 4 commits into from Nov 21, 2018
Merged

chore: update dependencies #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
294dda7
refactor: swap out fs-access for core fs
rogeriopvl Nov 21, 2018
38db702
chore: bump mocha, chai and sinon to latest
rogeriopvl Nov 21, 2018
b33f1b4
chore: bump standard to latest and fix lint
rogeriopvl Nov 21, 2018
1861a15
chore: update karma, grunt and related packages
rogeriopvl Nov 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
@@ -1,4 +1,4 @@
var fsAccess = require('fs-access')
var fs = require('fs')
var path = require('path')
var which = require('which')

Expand Down Expand Up @@ -63,7 +63,7 @@ function getChromeExe (chromeDirName) {
prefix = prefixes[i]
try {
windowsChromeDirectory = path.join(prefix, suffix)
fsAccess.sync(windowsChromeDirectory)
fs.accessSync(windowsChromeDirectory)
return windowsChromeDirectory
} catch (e) {}
}
Expand Down Expand Up @@ -112,7 +112,7 @@ function getChromiumExe (chromeDirName) {
prefix = prefixes[i]
try {
windowsChromiumDirectory = path.join(prefix, suffix)
fsAccess.sync(windowsChromiumDirectory)
fs.accessSync(windowsChromiumDirectory)
return windowsChromiumDirectory
} catch (e) {}
}
Expand Down Expand Up @@ -144,7 +144,7 @@ function getChromeDarwin (defaultPath) {

try {
var homePath = path.join(process.env.HOME, defaultPath)
fsAccess.sync(homePath)
fs.accessSync(homePath)
return homePath
} catch (e) {
return defaultPath
Expand Down
15 changes: 7 additions & 8 deletions package.json
View file
Open in desktop
Expand Up @@ -19,27 +19,26 @@
],
"author": "Vojta Jina <vojta.jina@gmail.com>",
"dependencies": {
"fs-access": "^1.0.0",
"which": "^1.2.1"
},
"license": "MIT",
"devDependencies": {
"chai": "^3.3.0",
"chai": "^4.2.0",
"grunt": "^1.0.1",
"grunt-auto-release": "^0.0.7",
"grunt-bump": "^0.8.0",
"grunt-conventional-changelog": "^6.1.0",
"grunt-conventional-github-releaser": "^1.0.0",
"grunt-karma": "1.x || ^0.12.1",
"grunt-karma": "^3.0.0",
"grunt-npm": "^0.0.2",
"grunt-simple-mocha": "^0.4.0",
"jasmine-node": "^1.14.5",
"karma": "1.x || ^0.13.10",
"karma": "^3.1.1",
"karma-mocha": "1.x || ^0.2.0",
"load-grunt-tasks": "^3.2.0",
"mocha": "^3.2.0",
"sinon": "^2.0.0",
"standard": "^10.0.0"
"load-grunt-tasks": "^4.0.0",
"mocha": "^5.2.0",
"sinon": "^7.1.1",
"standard": "^12.0.0"
},
"contributors": [
"Mark Ethan Trostler <mark@zzo.com>",
Expand Down
2 changes: 1 addition & 1 deletion test/jsflags.spec.js
View file
Open in desktop
Expand Up @@ -46,7 +46,7 @@ describe('canaryGetOptions', function () {
var parent = sinon.stub().returns(['-incognito'])
var context = {}
var url = 'http://localhost:9876'
var args = {flags: ['--js-flags="--expose-gc"']}
var args = { flags: ['--js-flags="--expose-gc"'] }
expect(canaryGetOptions.call(context, url, args, parent)).to.be.eql([
'-incognito',
'--js-flags=--expose-gc --nocrankshaft --noopt'
Expand Down