Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin idna<3 version becasue of version conflict between urlextract & requests #239

Merged
merged 1 commit into from May 10, 2021

Conversation

karlicoss
Copy link
Owner

can be resolved after psf/requests#5710 is fixed

@seanbreckenridge
Copy link
Contributor

seanbreckenridge commented Oct 21, 2021

@karlicoss since psf/requests#5868 has been merged, I think the pin can be removed?

Causes an error for me because of version conflicts with other stuff I have installed:

$ promnesia index
Traceback (most recent call last):
  File "/home/sean/.local/lib/python3.9/site-packages/pkg_resources/__init__.py", line 568, in _build_master
    ws.require(__requires__)
  File "/home/sean/.local/lib/python3.9/site-packages/pkg_resources/__init__.py", line 886, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/home/sean/.local/lib/python3.9/site-packages/pkg_resources/__init__.py", line 777, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (idna 3.3 (/home/sean/.local/lib/python3.9/site-packages), Requirement.parse('idna<3'), {'promnesia'})

karlicoss added a commit that referenced this pull request Oct 27, 2021
introduced in #239
looks like not needed anymore since the `requests` issue was fixed
@karlicoss karlicoss mentioned this pull request Oct 27, 2021
@karlicoss
Copy link
Owner Author

yep, good catch, looks like not needed anymore

karlicoss added a commit that referenced this pull request Oct 27, 2021
introduced in #239
looks like not needed anymore since the `requests` issue was fixed
karlicoss added a commit that referenced this pull request Oct 27, 2021
introduced in #239
looks like not needed anymore since the `requests` issue was fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants