Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix travis builds #94

Closed
wants to merge 6 commits into from
Closed

fix travis builds #94

wants to merge 6 commits into from

Conversation

nijikon
Copy link
Member

@nijikon nijikon commented Nov 2, 2019

No description provided.

@mensfeld
Copy link
Member

mensfeld commented Nov 2, 2019

Irony: now all fail :D which is good - at least a bit of predictability 💃

@rgo
Copy link

rgo commented Nov 2, 2019

Locally, if I run consumer_spec.rb it consistently fails (Assertion failed error) in Consumer#seek subscription context:

Rdkafka::Consumer
  #subscripe, #unsubscribe and #subscription
    should subscribe, unsubscribe and return the subscription
    should raise an error when subscribing fails
    should raise an error when unsubscribing fails
    should raise an error when fetching the subscription fails
  #pause and #resume
    should raise when not TopicPartitionList
    should raise an error when pausing fails
    should raise an error when resume fails
    subscription
      should pause and then resume
  #seek
    should raise an error when seeking fails
    subscription
Assertion failed: (r == 0), function rwlock_wrlock, file tinycthread_extra.c, line 138.

[Process exited 134]

Running #seek context isolated works.

@rgo
Copy link

rgo commented Nov 2, 2019

Irony: now all fail :D which is good - at least a bit of predictability 💃

It seems to be failing because dockerize is not installed or something like that:

$ dockerize -wait tcp://localhost:2181 -timeout 1m
dockerize: command not found

https://travis-ci.org/appsignal/rdkafka-ruby/jobs/606363122#L421

@nijikon
Copy link
Member Author

nijikon commented Nov 2, 2019

@mensfeld @rgo this is a draft, be patient 😸

@nijikon
Copy link
Member Author

nijikon commented Nov 2, 2019

@thijsc could you give me some more privileges so I can cancel builds on travis? Right now I can't.

@thijsc
Copy link
Collaborator

thijsc commented Nov 12, 2019

I'm also working on this in #98

@thijsc
Copy link
Collaborator

thijsc commented Nov 12, 2019

Did you get a green build locally by the way?

@thijsc
Copy link
Collaborator

thijsc commented Feb 18, 2020

Thanks for your work on this! The build was fixed in #108 in the end.

@thijsc thijsc closed this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants