Bump librdkafka to 1.3.0 #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Free ptr objects in ensure blocks and add workaround for lack of read(:pointer), read_string_to_null and read_int64 ffi methods in JRuby Add JRuby 9.2.9.0 to travis WIP: Debugging. Modify error_spec and skip the spec using fork in JRuby. Use RbConfig to check for MacOS. WIP: Free @native_kafka in the consumer/producer during close Manually free the AutoPointer using ruby instead of a C call Switch to confluence docker images ProducerSpec: Closing the IO in forked process Avoiding AutoPointer instances being copied into forked process Alter the consumer spec to test for the message produced Remove consumer commit after assertions and increase the handle wait for JRuby for reason still unknown Rely on GC to call the finalizer to close @native_kafka socket Revert "Rely on GC to call the finalizer to close @native_kafka socket" This reverts commit 38ea6d6. Skip AutoPointer for consumer class Remove rd_kafka_consumer_close as rd_kafka_destroy takes care of it for consumers Adding rd_kafka_consumer_close and ensure it is only called once Skip fork spec Revert "Skip fork spec" This reverts commit d4cfb58. Remove autorelease and free pointers accessed using read_pointer
When converting a Rdkafka::TopicPartitionList to a native type, Rdkafka was depending on AutoPointer to eventually free them. There are a couple cases where a Client handle returns a pointer to the application that the application is then required to free, which could be leading to test instability. This takes a pass at ensuring all uses of native TopicPartitionList instances (even those return) are deterministically freed. Ensure poll returns nil after a consumer is closed Add the read_array_of_uint64 workaround for JRuby
…stroy will result in a segmentation fault but not #free
…4_t. Use AutoPointer#free in producer instead of rd_kafka_destroy to close @native_kafka instances if consumer#close is not called.
…calls the delivery callback
|
The bump to 1.3.0 was done in #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes from #108 and 0bf8909 to run the specs against
librdkafka v1.3.0.