-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JRuby and fix travis failures #108
Commits on Feb 4, 2020
-
Use *_ptrptr naming of MemoryPointer objects in consumer.rb
Free ptr objects in ensure blocks and add workaround for lack of read(:pointer), read_string_to_null and read_int64 ffi methods in JRuby Add JRuby 9.2.9.0 to travis WIP: Debugging. Modify error_spec and skip the spec using fork in JRuby. Use RbConfig to check for MacOS. WIP: Free @native_kafka in the consumer/producer during close Manually free the AutoPointer using ruby instead of a C call Switch to confluence docker images ProducerSpec: Closing the IO in forked process Avoiding AutoPointer instances being copied into forked process Alter the consumer spec to test for the message produced Remove consumer commit after assertions and increase the handle wait for JRuby for reason still unknown Rely on GC to call the finalizer to close @native_kafka socket Revert "Rely on GC to call the finalizer to close @native_kafka socket" This reverts commit 38ea6d6. Skip AutoPointer for consumer class Remove rd_kafka_consumer_close as rd_kafka_destroy takes care of it for consumers Adding rd_kafka_consumer_close and ensure it is only called once Skip fork spec Revert "Skip fork spec" This reverts commit d4cfb58. Remove autorelease and free pointers accessed using read_pointer
Adithya Pentela committedFeb 4, 2020 Configuration menu - View commit details
-
Copy full SHA for 5df8f9b - Browse repository at this point
Copy the full SHA 5df8f9bView commit details -
Ensure the consumer always destroy native TopicPartitionList
When converting a Rdkafka::TopicPartitionList to a native type, Rdkafka was depending on AutoPointer to eventually free them. There are a couple cases where a Client handle returns a pointer to the application that the application is then required to free, which could be leading to test instability. This takes a pass at ensuring all uses of native TopicPartitionList instances (even those return) are deterministically freed. Ensure poll returns nil after a consumer is closed Add the read_array_of_uint64 workaround for JRuby
Configuration menu - View commit details
-
Copy full SHA for 9e66368 - Browse repository at this point
Copy the full SHA 9e66368View commit details -
Call AutoPointer#free while closing the producer. Calling rd_kafka_de…
…stroy will result in a segmentation fault but not #free
Adithya Pentela committedFeb 4, 2020 Configuration menu - View commit details
-
Copy full SHA for 3f1b655 - Browse repository at this point
Copy the full SHA 3f1b655View commit details -
Using ternary operator to make code climate happy
Adithya Pentela committedFeb 4, 2020 Configuration menu - View commit details
-
Copy full SHA for db9c75e - Browse repository at this point
Copy the full SHA db9c75eView commit details
Commits on Feb 5, 2020
-
Use read_array_of_int64 as rd_kafka_query_watermark_offsets uses int6…
…4_t. Use AutoPointer#free in producer instead of rd_kafka_destroy to close @native_kafka instances if consumer#close is not called.
Adithya Pentela committedFeb 5, 2020 Configuration menu - View commit details
-
Copy full SHA for caf3f02 - Browse repository at this point
Copy the full SHA caf3f02View commit details -
Adithya Pentela committed
Feb 5, 2020 Configuration menu - View commit details
-
Copy full SHA for f9732b6 - Browse repository at this point
Copy the full SHA f9732b6View commit details -
Bump the timeout to see if it resolve travis failure for JRuby
Adithya Pentela committedFeb 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 914faf0 - Browse repository at this point
Copy the full SHA 914faf0View commit details
Commits on Feb 14, 2020
-
Added the missing watermarks_test_topic. Added exit! in fork spec
Adithya Pentela committedFeb 14, 2020 Configuration menu - View commit details
-
Copy full SHA for 0dd1a0d - Browse repository at this point
Copy the full SHA 0dd1a0dView commit details
Commits on Feb 16, 2020
-
Avoid sharing the socket in forked process
Adithya Pentela committedFeb 16, 2020 Configuration menu - View commit details
-
Copy full SHA for 3e5331a - Browse repository at this point
Copy the full SHA 3e5331aView commit details -
Ensure sockets are closed in specs
Adithya Pentela committedFeb 16, 2020 Configuration menu - View commit details
-
Copy full SHA for 6d7b472 - Browse repository at this point
Copy the full SHA 6d7b472View commit details -
Adithya Pentela committed
Feb 16, 2020 Configuration menu - View commit details
-
Copy full SHA for a93f720 - Browse repository at this point
Copy the full SHA a93f720View commit details -
Add a sleep to let the thread that uses Binding#DeliveryCallback to f…
…inish processing
Adithya Pentela committedFeb 16, 2020 Configuration menu - View commit details
-
Copy full SHA for c4d4d30 - Browse repository at this point
Copy the full SHA c4d4d30View commit details -
Adithya Pentela committed
Feb 16, 2020 Configuration menu - View commit details
-
Copy full SHA for 1a49c50 - Browse repository at this point
Copy the full SHA 1a49c50View commit details
Commits on Feb 17, 2020
-
Adithya Pentela committed
Feb 17, 2020 Configuration menu - View commit details
-
Copy full SHA for 2e27b7f - Browse repository at this point
Copy the full SHA 2e27b7fView commit details
Commits on Feb 18, 2020
-
Using Producer#close to eliminate the race with producer thread that …
…calls the delivery callback
Adithya Pentela committedFeb 18, 2020 Configuration menu - View commit details
-
Copy full SHA for 8e945fc - Browse repository at this point
Copy the full SHA 8e945fcView commit details