feat: add support for ldap compare request #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobikris
force-pushed
the
implement-compare
branch
from
42f8780
to
a3e4627
Compare
yaleman
reviewed
May 20, 2024
Firstyear
requested changes
May 21, 2024
tobikris
force-pushed
the
implement-compare
branch
2 times, most recently
from
82e06f5
to
fefe698
Compare
Firstyear
previously approved these changes
May 23, 2024
3 tasks
tobikris
force-pushed
the
implement-compare
branch
2 times, most recently
from
2782ade
to
1ccb15a
Compare
|
This may need a rebase to latest master before we can merge but otherwise it looks great, thank you! |
Firstyear
approved these changes
May 24, 2024
auto-merge was automatically disabled
May 24, 2024 08:22
Head branch was pushed to by a user without write access
tobikris
force-pushed
the
implement-compare
branch
from
1ccb15a
to
1280465
Compare
I rebased, but this reset the auto-merge status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the LDAP CompareRequest. The implementation is
usingbased on the existingSearchoperation.I tried to follow this description of the request: https://ldap.com/the-ldap-compare-operation/.
As theSearchoperation is not exposing the reason for errors, I could not returninvalidDNSyntax.I decided on using the same authentication decision as for the
Search.Edit:
After the review, I changed the implementation to be standalone with copy-pasted code from
do_searchinstead of calling the method.Checklist