-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better WebAuthn and other error responses #2608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaleman
force-pushed
the
passkey-error-logging
branch
from
March 2, 2024 09:38
b9ed69d
to
031acc0
Compare
Firstyear
reviewed
Mar 4, 2024
yaleman
force-pushed
the
passkey-error-logging
branch
from
June 4, 2024 02:16
031acc0
to
1a2c650
Compare
@Firstyear I cleaned up the regex silliness 😄 ... those cache test fails are weird, I can't tell how I touched anything in a way that'd break just them? |
Firstyear
reviewed
Jun 4, 2024
Firstyear
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that thing where if you don't have UV you should get a slightly nicer error.
Checklist