Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better WebAuthn and other error responses #2608

Merged
merged 15 commits into from
Jun 4, 2024

Conversation

yaleman
Copy link
Member

@yaleman yaleman commented Mar 2, 2024

Fixes that thing where if you don't have UV you should get a slightly nicer error.

Checklist

  • This pr contains no AI generated code
  • cargo fmt has been run
  • cargo clippy has been run
  • cargo test has been run and passes
  • book chapter included (if relevant)
  • design document included (if relevant)

@yaleman yaleman added the uwu ✧・゚: *✧・゚♡*(ᵘʷᵘ)*♡・゚✧*:・゚✧ label Mar 2, 2024
@yaleman yaleman requested a review from Firstyear March 2, 2024 09:41
@yaleman yaleman added the enhancement New feature or request label Mar 2, 2024
@yaleman yaleman self-assigned this May 14, 2024
@yaleman yaleman requested a review from Firstyear June 4, 2024 03:25
@yaleman
Copy link
Member Author

yaleman commented Jun 4, 2024

@Firstyear I cleaned up the regex silliness 😄

... those cache test fails are weird, I can't tell how I touched anything in a way that'd break just them?

@yaleman yaleman requested a review from Firstyear June 4, 2024 06:08
@Firstyear Firstyear merged commit 3c01a96 into kanidm:master Jun 4, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request uwu ✧・゚: *✧・゚♡*(ᵘʷᵘ)*♡・゚✧*:・゚✧
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants