Spike on deprecating #current_page method #990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #909, #925 and #989
I could finally took the time to look into this, and it doesn't seem to be very difficult to deprecate the
#current_page
method. The rationale here is that it always returns the same value asparams[:page]
(or whatever is specified through the:param_name
option) and there is no need to re-compute the current page.:param_name
option (e.g. needs to look atparams[:user][:page]
when the:param_name
isuser[page]
)scope#current_page
(ActiveAdmin)