Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization issue for foreign-language models - now uses correct… #892

Closed
wants to merge 1 commit into from

Conversation

phrozen77
Copy link

Now does display the right localization :)

Also, please don't shoot me if i did something wrong - first pull requeste & fix for a gem :)

best regards,
Christian

@yuki24
Copy link
Member

yuki24 commented May 26, 2017

@phrozen77 The implementation looks good to me. One thing though, could you add a test case for this change?

@yuki24 yuki24 self-assigned this May 26, 2017
@phrozen77
Copy link
Author

phrozen77 commented May 27, 2017

I tried to and.. failed :)

I've added the following to test/requests/navigation_test.rb:

within 'div.info' do
I18n.enforce_available_locales = false
I18n.locale = :de
assert page.has_text? 'Displaying user 1'
end

However, since my app neither has english nor i can really see what output the test suite produces i'm a little bit at a loss?

@hundred
Copy link
Contributor

hundred commented Jul 10, 2017

@phrozen77 , @yuki24 i created a PR with tests here:
#899
really need this feature to work :)
let me know how you want to handle this

@phrozen77
Copy link
Author

No hard feelings, heh :)

Once your PR is merged i'll close mine...

Thank you for caring, @hundred :)

@yuki24
Copy link
Member

yuki24 commented Jul 17, 2017

I'm closing this PR in favor of #899. Thank you all for taking your time and working on this!

@yuki24 yuki24 closed this Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants