Exclude path_params from page_url_for params keys #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to add
path_params=valto the url and cause 500 errors when this code is invoked by kaminari. Exclude it from params to avoid this problem.I thought about trying to patch this in rails, but I think passing all of
@paramsto url_for is not happening regularly. Let me know if you disagree.EDIT: It would seem it is not currently possible to control the params that are passed to
url_for. Passingparams:to paginate only adds to the params instead of replacing them. This means the solution requires altering the globalparamsas in rubygems/rubygems.org#4580.