Minor documentation improvements #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatsuda
reviewed
Mar 26, 2024
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Kaminari [](https://github.com/kaminari/kaminari/actions) [](https://codeclimate.com/github/kaminari/kaminari) | |||
|
|
|||
| A Scope & Engine based, clean, powerful, customizable and sophisticated paginator for modern web app frameworks and ORMs | |||
| A Scope & Engine based, clean, powerful, customizable and sophisticated paginator for modern web app frameworks and ORMs. | |||
There was a problem hiding this comment.
Do we need this change? I think this line is not a sentence.
There was a problem hiding this comment.
@amatsuda thinking about it you are right. I have removed this change 馃槂.
Uaitt
force-pushed
the
documentation-improvements
branch
from
0a74cc6
to
7345d94
Compare
|
@Uaitt Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the README of this gem I noticed a few very small things that could have been improved. This PR addresses those things 馃槂.