Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix using symbol as param_name that raise an error in params_for #1121

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix using symbol as param_name that raise an error in params_for #1121

merged 2 commits into from
Mar 19, 2024

Conversation

magnum
Copy link
Contributor

@magnum magnum commented Mar 15, 2024

fix using symbol as param_name that raise an error in params_for, fixes #1120

@yuki24
Copy link
Member

yuki24 commented Mar 16, 2024

Could you add a test that covers this case?

@magnum
Copy link
Contributor Author

magnum commented Mar 17, 2024

Could you add a test that covers this case?

test added, @yuki24 thank you for your time

@yuki24
Copy link
Member

yuki24 commented Mar 19, 2024

Thanks!

@yuki24 yuki24 merged commit 5438e08 into kaminari:master Mar 19, 2024
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using symbol as param_name gives an error in params_for
2 participants
@magnum @yuki24