Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated usage of ActiveSupport::Deprecation singleton #1103

Conversation

etiennebarrie
Copy link
Contributor

Rails 7.1 will deprecate usage of the ActiveSupport::Deprecation singleton (calling warn, silence, etc. directly on it) (see rails/rails#47354).

This PR defines an instance of ActiveSupport::Deprecation for the gem and uses it.

It's also added to the application's set of deprecators, allowing it to be configured along all the other deprecators.

@amatsuda amatsuda force-pushed the remove-active-support-deprecation-usage branch from 45badd3 to 8978e70 Compare May 25, 2023 21:54
@amatsuda
Copy link
Member

@etiennebarrie Thank you!

@amatsuda amatsuda merged commit 1f4a49a into kaminari:master May 25, 2023
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants