Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor pagination #1101

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Cursor pagination #1101

wants to merge 19 commits into from

Commits on Aug 29, 2022

  1. Impl cursor pagination

    @khuston
    khuston committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    640b767 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Handle null values in cursor pagination

    @khuston
    khuston committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    8fab05f View commit details
    Browse the repository at this point in the history

  2. Dry cursor pagination

    @khuston
    khuston committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    b24116b View commit details
    Browse the repository at this point in the history

  3. Add unit tests, simplify cursor param, fix bug

    @khuston
    khuston committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    d39c721 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Add unit tests. Failure due to relation immutability

    @khuston
    khuston committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    9d77ccb View commit details
    Browse the repository at this point in the history

  2. Fix immutability error by mutating relation earlier for cursor paging

    @khuston
    khuston committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    ab08ba4 View commit details
    Browse the repository at this point in the history

  3. Embed search direction in cursor param and add tests

    @khuston
    khuston committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    59a69e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Add view tests for cursor pagination and fix bug

    @khuston
    khuston committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    2bfe1f1 View commit details
    Browse the repository at this point in the history

  2. Add tests covering nulls first/last and fix issue

    @khuston
    khuston committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    070f3fa View commit details
    Browse the repository at this point in the history

  3. Test explicit id order is not changed

    @khuston
    khuston committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    987b917 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Use microsecond precision for times in cursor

    @khuston
    khuston committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    0e48291 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Serialize timestamp directly rather than rely on as_json monkeypatch

    @khuston
    khuston committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1d4fbbc View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Fix name collision on joined relations

    @khuston
    khuston committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    5cfef62 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Improve comments and serialize to nanoseconds instead of microseconds

    @khuston
    khuston committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    83c2e05 View commit details
    Browse the repository at this point in the history

  2. Replace &. with .try to be compatible with Ruby <2.3

    @khuston
    khuston committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    249fa41 View commit details
    Browse the repository at this point in the history

  3. Rename .match? to .match for Ruby <2.3

    @khuston
    khuston committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    3530f19 View commit details
    Browse the repository at this point in the history

  4. Change .filter! to .keep_if for old Ruby

    @khuston
    khuston committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    b39b945 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. Unquote identifiers according to db adapter type

    @khuston
    khuston committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    1c1694a View commit details
    Browse the repository at this point in the history

  2. Avoid .pluck method

    @khuston
    khuston committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    9da0cae View commit details
    Browse the repository at this point in the history