Stop displaying first page link on second page pagination and last page link on penultimate page pagination #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge link on penultimate page pagination
|
Thanks for your PR. This is an interesting change, and I think it makes total sense to reduce duplicate links whenever possible. @amatsuda do you think we should be concerned about any sort of compatibility here? It might be safe to do this, btu also could be surprising to remove user-facing links. |
|
Harumpf. So if I randomly click on page numbers and I happen to land on page 2 all of a sudden I have to change modes and click on 'First' if I want to go to page 1. Likewise for the one-but-last page. It might be me but I should have an UX expert look at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a problem in ActiveAdmin pagination I found this unexpected behaviour.
I expected the first page link to not be shown in the second page pagination because it does exactly the same as the previous page link. I'm not sure if this link duplication is on purpose or not.
I've created a quick spike with a possible alternative, let me know if any other work needs to be done. If you decide that the current behaviour is the correct, feel free to close this PR.
Thank you for the nice work maintaining this gem 💚