add pluralization based on locale setup for any language

[hundred]

this solves the issue with using .pluralize for languages like :de etc, that dont always add s on the end of the pluralized words

[yuki24]

Thanks so much! Overall, it looks awesome to me. I'll add a more detailed review later today.

[hundred]

@yuki24 did you have a chance to look at the PR yet? :)

[yuki24]

I wonder if this entire sub test case for :de is necessary when there is a test case for :fr. Are there any tests that fail without your change?

[yuki24]

This looks great 👍🏻

[yuki24]

Instead of using begin...ensure...end, I think it makes more sense to do this with setup do ... end and call a I18n.backend.reload! in teardown do ... end.

[hundred]

@yuki24 thanks for review, moved those now :)
the point of having :de in test was to show/make sure that pluralize wont auto-add an s to plural for that language,
if the change itself in the helper is ever questioned/removed, this will be the only test that fails as :fr uses the same logic as english for pluralization by mostly just adding an s in the end of the word
let me know if this makes sense :) ?

[yuki24]

the point of having :de in test was to show/make sure that pluralize wont auto-add an s to plural for that language

Thanks for the clarification. That makes a lot of sense.

Thanks for your contribution!

[zerocool4u2]

After some digging I notice that this works on 1.0.1 out of the box if you have inflectors for each language you wanted, but there is a problem on entry_name, but don't really know what exactly is...

I'm currently overwriting that method and it seems to work as expected:

module Kaminari
	module ActiveRecordRelationMethods
		extend Kaminari::ActiveRecordRelationMethods

		def self.included(base)
			base.send :extend, Kaminari::ActiveRecordRelationMethods
		end

		def entry_name(options = {})
			model_name.human.pluralize(options[:count])
		end
	end
end

if options is nil or :count is nil, it would be just one item by default on pluralize, same with a single item

[yuki24]

@zerocool4u2 I don't think I understand your issue. Please file a new issue with reproduction steps or a test case that fails.

[zerocool4u2]

I mean that this change

entry_name.pluralize(collection.size, I18n.locale)

Doesn't make any difference, pluralize already takes the current I18n.locale and if you have inflectors for pluralization it would pluralize any word out of the box, rather it would be more useful to modify entry_name so you get pluralization in local language without passing a entry_name variable to page_entries_info and leave entry_name option for when you want to use a different name in a determinate case.

Now this other method isn't working because default is just for when you don't have a translation http://guides.rubyonrails.org/i18n.html#defaults

def entry_name(options = {})
      default = options[:count] == 1 ? model_name.human : model_name.human.pluralize
      model_name.human(options.reverse_merge(default: default))
end

Maybe this is intended, but my suggestion would be to use something like this

def entry_name(options = {})
      model_name.human.pluralize(options[:count])
end

Hope that this clarifies what I was saying @yuki24 , basically I want this feature, but this isn't the solution :(

[yuki24]

@zerocool4u2 Again, please file a new issue with reproduction steps or a test case that fails and what you'd expect to see.