Take writer by value #125
Merged
Take writer by value #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is a small semver-major incompatibility. In one place I've used an overcomplicated But simple |
|
@kaj ping |
|
Hm. I have gone from simple to complex to more complex and to slightly simpler again on this type ... But you are probably write, back to the simplest possible is the way to go. |
|
Thanks for the contribution! |
kaj
added a commit
that referenced
this pull request
Jul 22, 2023
* Added a check that no more than one of the http-types, mime02, or mime03 features are enabled (PR #124). Thanks @rustafarian-dev. * Changed the writer type from `W: &mut Write` to just `W: Write` (PR #125). Thanks @kornelski! * Fixed handling of `MULTI_WORD_CONSTANTS` in templates (Issue #129, PR #130). Thanks @wezm! * More ways to create a working rust symbol name from a "strange" static file name. Illegal characters are replaced by `_`, and if the file name starts with a number it is prefixed with `n` (Issue #82, PR #132). Thanks @Aedius for reporting! * Fixed more clippy lints (PR #123, #127). Thanks @vbrandl! * Updated `rsass` to 0.28.0 and `itertools` to 0.11.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io::Writeis implemented for all&mut io::Write, so the&mutpart doesn't have to be explicit.Fixes #111