[Fix rubocop#10245] Remove Gemspec/DateAssignment

Gemspec/DateAssignment functionality is
integrated into Gemspec/DeprecatedAttributeAssignment

changelog/change_integrate_date_assignment_cop.md

@@ -0,0 +1 @@
+* [#10245](https://github.com/rubocop/rubocop/pull/10245): **(Breaking)** integrate `Gemspec/DateAssignment` into `Gemspec/DeprecatedAttributeAssignment`. ([@kaitielth][])

config/default.yml

@@ -235,13 +235,6 @@ Bundler/OrderedGems:
 
 #################### Gemspec ###############################
 
-Gemspec/DateAssignment:
-  Description: 'Checks that `date =` is not used in gemspec file, it is set automatically when the gem is packaged.'
-  Enabled: pending
-  VersionAdded: '1.10'
-  Include:
-    - '**/*.gemspec'
-
 Gemspec/DependencyVersion:
   Description: 'Requires or forbids specifying gem dependency versions.'
   Enabled: false

config/obsoletion.yml

@@ -55,6 +55,8 @@ renamed:
 
 # Cops that were removed
 removed:
+  Gemspec/DateAssignment:
+    alternatives: Gemspec/DeprecatedAttributeAssignment
   Layout/SpaceAfterControlKeyword:
     alternatives: Layout/SpaceAroundKeyword
   Layout/SpaceBeforeModifierKeyword:

docs/modules/ROOT/pages/cops.adoc

@@ -82,7 +82,6 @@ In the following section you find all available cops:
 
 === Department xref:cops_gemspec.adoc[Gemspec]
 
-* xref:cops_gemspec.adoc#gemspecdateassignment[Gemspec/DateAssignment]
 * xref:cops_gemspec.adoc#gemspecdependencyversion[Gemspec/DependencyVersion]
 * xref:cops_gemspec.adoc#gemspecdeprecatedattributeassignment[Gemspec/DeprecatedAttributeAssignment]
 * xref:cops_gemspec.adoc#gemspecduplicatedassignment[Gemspec/DuplicatedAssignment]

docs/modules/ROOT/pages/cops_gemspec.adoc

@@ -1,36 +1,5 @@
 = Gemspec
 
-== Gemspec/DateAssignment
-
-|===
-| Enabled by default | Safe | Supports autocorrection | Version Added | Version Changed
-
-| Pending
-| Yes
-| Yes
-| 1.10
-| -
-|===
-
-Checks that `date =` is not used in gemspec file.
-It is set automatically when the gem is packaged.
-
-=== Examples
-
-[source,ruby]
-----
-# bad
-Gem::Specification.new do |spec|
-  spec.name = 'your_cool_gem_name'
-  spec.date = Time.now.strftime('%Y-%m-%d')
-end
-
-# good
-Gem::Specification.new do |spec|
-  spec.name = 'your_cool_gem_name'
-end
-----
-
 === Configurable attributes
 
 |===

lib/rubocop.rb

@@ -160,7 +160,6 @@
 require_relative 'rubocop/cop/bundler/insecure_protocol_source'
 require_relative 'rubocop/cop/bundler/ordered_gems'
 
-require_relative 'rubocop/cop/gemspec/date_assignment'
 require_relative 'rubocop/cop/gemspec/dependency_version'
 require_relative 'rubocop/cop/gemspec/deprecated_attribute_assignment'
 require_relative 'rubocop/cop/gemspec/duplicated_assignment'

lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Cop
     module Gemspec
       # Checks that deprecated attribute attributes are not set in a gemspec file.
-      # Removing `test_files` allows the user to receive smaller packed gems.
+      # Removing deprecated attributes allows the user to receive smaller packed gems.
       #
       # @example
       #
@@ -29,7 +29,7 @@ class DeprecatedAttributeAssignment < Base
         include RangeHelp
         extend AutoCorrector
 
-        MSG = 'Do not set `test_files` in gemspec.'
+        MSG = 'Do not set `%<attribute>s` in gemspec.'
 
         # @!method gem_specification(node)
         def_node_matcher :gem_specification, <<~PATTERN
@@ -45,31 +45,46 @@ def on_block(block_node)
 
           block_parameter = block_node.arguments.first.source
 
-          date_assignment = block_node.descendants.detect do |node|
-            use_test_files?(node, block_parameter)
+          assignment = block_node.descendants.detect do |node|
+            use_deprecated_attributes?(node, block_parameter)
           end
+          return unless assignment
 
-          return unless date_assignment
-
-          add_offense(date_assignment) do |corrector|
-            range = range_by_whole_lines(date_assignment.source_range, include_final_newline: true)
+          message = format_message_from
+          add_offense(assignment, message: message) do |corrector|
+            range = range_by_whole_lines(assignment.source_range, include_final_newline: true)
 
             corrector.remove(range)
           end
         end
 
         private
 
-        def use_test_files?(node, block_parameter)
-          node, method_name = if node.op_asgn_type?
-                                lhs, _op, _rhs = *node
+        def node_and_method_name(node, attribute)
+          if node.op_asgn_type?
+            lhs, _op, _rhs = *node
+            [lhs, attribute]
+          else
+            [node, "#{attribute}=".to_sym]
+          end
+        end
+
+        def use_deprecated_attributes?(node, block_parameter)
+          %i[test_files date].each do |attribute|
+            node, method_name = node_and_method_name(node, attribute)
+            unless node.send_type? && node.receiver&.source == block_parameter &&
+                   node.method?(method_name)
+              next
+            end
 
-                                [lhs, :test_files]
-                              else
-                                [node, :test_files=]
-                              end
+            @attribute = attribute.to_s
+            return true
+          end
+          false
+        end
 
-          node.send_type? && node.receiver&.source == block_parameter && node.method?(method_name)
+        def format_message_from
+          format(MSG, attribute: @attribute)
         end
       end
     end