Prefer as const with TypeScript 4.9 introduced satisfies (#415)

* Prefer `as const` with TypeScript 4.9 introduced `satisfies`

microsoft/TypeScript#47920
https://devblogs.microsoft.com/typescript/announcing-typescript-4-9-rc/#satisfies

* `npm install --save-dev @typescript-eslint/eslint-plugin@5.44.1-alpha.6 && npm install --save-dev @typescript-eslint/parser@5.44.1-alpha.6`

* `npm install --save-dev --legacy-peer-deps @typescript-eslint/eslint-plugin@5.44.1-alpha.6 @typescript-eslint/parser@5.44.1-alpha.6`

* npm/cli#4998

* Need here too

* Add TODO comments

.github/workflows/ci-official.yml

@@ -41,7 +41,8 @@ jobs:
         with:
           node-version: '${{ fromJson(needs.asdf-parser.outputs.tool-versions).nodejs }}'
           cache: npm
-      - run: npm ci # `--ignore-scripts` do not cover RE2
+      # TODO: Revert `--legacy-peer-deps` after typescript-eslint released 5.44.1 or later. See https://github.com/kachick/renovate-config-asdf/pull/415
+      - run: npm ci --legacy-peer-deps # `--ignore-scripts` do not cover RE2
       # renovate.json will always tested by the CLI
       - run: RENOVATE_CONFIG_FILE=default.json npx renovate-config-validator
       - run: RENOVATE_CONFIG_FILE=self.json npx renovate-config-validator

.github/workflows/ci-typescript.yml

@@ -38,7 +38,8 @@ jobs:
         with:
           node-version: '${{ fromJson(needs.asdf-parser.outputs.tool-versions).nodejs }}'
           cache: npm
-      - run: npm ci
+      # TODO: Revert `--legacy-peer-deps` after typescript-eslint released 5.44.1 or later. See https://github.com/kachick/renovate-config-asdf/pull/415
+      - run: npm ci --legacy-peer-deps
       - run: npx tsc
       - run: make eslint-check
       - run: npx ts-node-test test/*.ts

.vscode/settings.json

@@ -1,4 +1,5 @@
 {
+  "typescript.tsdk": "node_modules/typescript/lib",
   "editor.defaultFormatter": "dprint.dprint",
   "editor.formatOnSave": true,
   "cSpell.words": [

package.json

@@ -2,8 +2,8 @@
   "devDependencies": {
     "@tsconfig/node18-strictest-esm": "^1.0.1",
     "@types/node": "^18.11.9",
-    "@typescript-eslint/eslint-plugin": "^5.44.0",
-    "@typescript-eslint/parser": "^5.44.0",
+    "@typescript-eslint/eslint-plugin": "^5.44.1-alpha.6",
+    "@typescript-eslint/parser": "^5.44.1-alpha.6",
     "eslint": "^8.28.0",
     "eslint-plugin-deprecation": "^1.3.3",
     "eslint-plugin-import": "^2.26.0",

test/examples.ts

@@ -4,7 +4,7 @@ interface Example {
   extracted: string;
 }
 
-export const examples: Readonly<Readonly<Example>[]> = [
+export const examples = [
   {
     plugin: 'bun',
     source: 'bun-v0.1.11',
@@ -131,4 +131,4 @@ export const examples: Readonly<Readonly<Example>[]> = [
     source: 'v0.31.3',
     extracted: '0.31.3',
   },
-];
+] as const satisfies Readonly<Readonly<Example>[]>;

test/regex_test.ts

@@ -31,7 +31,8 @@ interface RegExManager extends RegexManagerTemplates {
 }
 
 void test('extractVersionTemplate', async (t) => {
-  const plugins = new Set(examples.map((example) => example.plugin));
+  // https://github.com/microsoft/TypeScript/issues/14520#issuecomment-853946018 :<
+  const plugins = new Set(examples.map((example) => example.plugin as string));
 
   for (const basename of fs.readdirSync('plugins')) {
     const pluginPath = path.join('plugins', basename);