Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key order compliance #298

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

brandond
Copy link
Contributor

@brandond brandond commented May 7, 2024

Changes:

  • Create local signals package to eliminate wrangler import
  • Bump etcd module versions
  • Sort list results by name, not revision. List continuation (start key) functionality requires that keys be returned in ascending order.
  • Only count keys remaining after the start key, not the total number of keys in the prefix.
  • Return current revision in header along with error when unable to range on key.
  • Don't ignore start key when listing with revision=0
  • Update CI tests - bump k3s to v1.29.4+k3s1, and add basic sig-api-machinery e2e against sqlite and nats-embedded

@brandond brandond requested a review from a team as a code owner May 7, 2024 23:02
@brandond brandond force-pushed the fix-key-order-compliance branch 2 times, most recently from 4286268 to 4070872 Compare May 8, 2024 01:47
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond force-pushed the fix-key-order-compliance branch 9 times, most recently from 7c7eb06 to 2367648 Compare May 8, 2024 22:50
* Sort list results by name, not revision. List continuation (start key)
  functionality requires that keys be returned in ascending order.
* Only count keys remaining after the start key, not the total number of
  keys in the prefix.
* Return current revision in header along with error when unable to
  range on key.
* Don't ignore start key when listing with revision=0

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Bump k3s to v1.29.4+k3s1, and add basic sig-api-machinery e2e against sqlite and nats

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
Copy link
Contributor Author

brandond commented May 8, 2024

hey @bruth are you able to take a look at the CI failures here, when running the Kubernetes sig-api-machinery e2e tests against a cluster using kine+nats-embedded? It appears to be failing on some pretty basic stuff:
https://github.com/kubernetes/kubernetes/blob/v1.29.4/test/e2e/apimachinery/apply.go#L248

[nats-embedded] • [FAILED] [0.397 seconds]
[nats-embedded] [sig-api-machinery] ServerSideApply [It] should work for subresources [sig-api-machinery]
[nats-embedded] k8s.io/kubernetes/test/e2e/apimachinery/apply.go:165
[nats-embedded] 
[nats-embedded]   Timeline >>
[nats-embedded]   STEP: Creating a kubernetes client @ 05/08/24 23:35:41.137
[nats-embedded]   May  8 23:35:41.137: INFO: >>> kubeConfig: /root/.kube/config
[nats-embedded]   STEP: Building a namespace api object, basename apply @ 05/08/24 23:35:41.138
[nats-embedded]   STEP: Waiting for a default service account to be provisioned in namespace @ 05/08/24 23:35:41.146
[nats-embedded]   STEP: Waiting for kube-root-ca.crt to be provisioned in namespace @ 05/08/24 23:35:41.148
[nats-embedded]   [FAILED] in [It] - k8s.io/kubernetes/test/e2e/apimachinery/apply.go:248 @ 05/08/24 23:35:41.169

[nats-embedded]   << Timeline
[nats-embedded] 
[nats-embedded]   [FAILED] Failed to Apply Status using Apply patch: pods "test-pod" not found
[nats-embedded]   In [It] at: k8s.io/kubernetes/test/e2e/apimachinery/apply.go:248 @ 05/08/24 23:35:41.169

https://drone-pr.k3s.io/k3s-io/kine/486/1/9

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond merged commit 5a50c68 into k3s-io:master May 9, 2024
3 checks passed
@bruth
Copy link
Contributor

bruth commented May 14, 2024

@brandond Hey, sorry for the late response. I was traveling last week. I will take a look at it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants