Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for containerd hosts.toml bug when passing config for default registry endpoint #9853

Merged
merged 1 commit into from Apr 4, 2024

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Apr 1, 2024

Proposed Changes

Add base [host] tree to containerd hosts.toml to work around containerd bug

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner April 1, 2024 23:14
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.73%. Comparing base (7f65975) to head (f3bed77).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9853      +/-   ##
==========================================
- Coverage   52.67%   46.73%   -5.94%     
==========================================
  Files         157      157              
  Lines       13822    13822              
==========================================
- Hits         7281     6460     -821     
- Misses       5155     6125     +970     
+ Partials     1386     1237     -149     
Flag Coverage Δ
e2etests 39.76% <ø> (-9.50%) ⬇️
inttests 39.42% <ø> (+17.29%) ⬆️
unittests 16.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants