Disable urfave markdown/man docs generation #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briandowns
approved these changes
May 18, 2022
briandowns
approved these changes
May 20, 2022
nikolaishields
approved these changes
May 23, 2022
brandond
force-pushed
the
cli_no_docs
branch
5 times, most recently
from
a964d0e
to
06721e9
Compare
From urfave/cli#1383 : > This removes the resulting binary dependency on cpuguy83/md2man and > russross/blackfriday (and a few more packages imported by those), > which saves more than 400 KB (more than 300 KB > once stripped) from the resulting binary. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
|
merging with rebase to fix go.mod conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Disable urfave markdown/man docs generation. We're not using either of these, so it's just bloat.
From urfave/cli#1383 :
A/B comparison of builds without/with this commit:
This is a savings of 1192 Kb - just shy of 1MiB.
Types of Changes
size reduction
Verification
Check size of resulting K3s binary
Linked Issues
User-Facing Change
Further Comments