Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capture/runbook.go reading out request body when multipart/form-data #345

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Dec 5, 2022

Fix #342

@k1LoW k1LoW added the bug Something isn't working label Dec 5, 2022
@k1LoW k1LoW self-assigned this Dec 5, 2022
@k1LoW k1LoW changed the title Fix capture/runbook.go reading out request body Fix capture/runbook.go reading out request body when multipart/form-data Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Code Metrics Report

main (7de26d6) #345 (442652b) +/-
Coverage 75.2% 75.1% -0.1%
Code to Test Ratio 1:0.7 1:0.7 +0.0
Details
  |                    | main (7de26d6) | #345 (442652b) |  +/-  |
  |--------------------|----------------|----------------|-------|
- | Coverage           |          75.2% |          75.1% | -0.1% |
  |   Files            |             35 |             35 |     0 |
  |   Lines            |           3831 |           3825 |    -6 |
- |   Covered          |           2882 |           2873 |    -9 |
+ | Code to Test Ratio |          1:0.7 |          1:0.7 |  +0.0 |
  |   Code             |           8289 |           8281 |    -8 |
  |   Test             |           5430 |           5430 |     0 |

Code coverage of files in pull request scope (67.7% → 65.7%)

Files Coverage +/-
http.go 80.3% -0.6%
yaml.go 40.7% -1.9%

Reported by octocov

@k1LoW k1LoW requested a review from k2tzumi December 5, 2022 11:58
@k1LoW
Copy link
Owner Author

k1LoW commented Dec 5, 2022

@k2tzumi
It seems that the problem was that capture/runbook.go had read through the request body. I hope you can try it in your environment!

Copy link
Collaborator

@k2tzumi k2tzumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error resolved in my environment.
Thank you for the correction.

@k2tzumi k2tzumi merged commit 5b08e16 into main Dec 5, 2022
@k2tzumi k2tzumi deleted the fix-capture-drainbody branch December 5, 2022 13:56
@github-actions github-actions bot mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants