Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning on Rails 6 #138

Merged
merged 1 commit into from Apr 9, 2019
Merged

Fix deprecation warning on Rails 6 #138

merged 1 commit into from Apr 9, 2019

Conversation

r7kamura
Copy link
Contributor

@r7kamura r7kamura commented Apr 9, 2019

When trying rails 6.0.0.beta3 with hamlit 2.9.2, I found a following deprecation warning:

DEPRECATION WARNING: Single arity template handlers are deprecated.  Template handlers must
now accept two parameters, the view object and the source for the view object.
Change:
  >> Hamlit::RailsTemplate#call(template)
To:
  >> Hamlit::RailsTemplate#call(template, source)

This pull request brings hamlit template handler up to work with Rails 6 and no deprecation warnings.

See also:

k0kubun
k0kubun approved these changes Apr 9, 2019
View reviewed changes
Copy link
Owner

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@k0kubun k0kubun merged commit 1614ddb into k0kubun:master Apr 9, 2019
@r7kamura r7kamura deleted the feature/rails-6-0 branch April 9, 2019 03:17
@kalvinchang kalvinchang mentioned this pull request Jul 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r7kamura @k0kubun