Override the timestamp key used in zerolog #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents it from replacing `time` keys on logs, particularly for pgx First part of a fix for authzed/spicedb#58
|
@jzelinskie Let me know if you prefer this to be a function that importers call instead |
jzelinskie
reviewed
Apr 5, 2023
| // override the `time` field name to not conflict with other existing `time` fields | ||
| // in logs. | ||
| // See: https://github.com/rs/zerolog/blob/1f50797d7d24e4cf3a6407203bd694f3d35de724/event.go#L643 | ||
| zerolog.TimestampFieldName = "log-timestamp" |
There was a problem hiding this comment.
Should this be in init or New? I could see someone importing this library in the future while not desiring this side affect.
There was a problem hiding this comment.
That was my question: or should it be a function we export from here that the importer calls?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents it from replacing
timekeys on logs, particularly for pgxFirst part of a fix for authzed/spicedb#58