Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Co-authored-by: Christina Troger <christroger@github.com>
  • Loading branch information
cjs and christroger committed Jan 27, 2022
1 parent 21e5e5d commit f44ebf2
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions cobrautil.go
Expand Up @@ -176,19 +176,19 @@ func OpenTelemetryRunE(flagPrefix string, prerunLevel zerolog.Level) CobraRunFun
if err != nil {
return err
}
return initOtlpTracer(exporter, serviceName)
return initOtelTracer(exporter, serviceName)
case "otlphttp":
exporter, err := otlptrace.New(context.Background(), otlptracehttp.NewClient())
if err != nil {
return err
}
return initOtlpTracer(exporter, serviceName)
return initOtelTracer(exporter, serviceName)
case "otlpgrpc":
exporter, err := otlptrace.New(context.Background(), otlptracegrpc.NewClient())
if err != nil {
return err
}
return initOtlpTracer(exporter, serviceName)
return initOtelTracer(exporter, serviceName)
default:
return fmt.Errorf("unknown tracing provider: %s", provider)
}
Expand All @@ -198,7 +198,7 @@ func OpenTelemetryRunE(flagPrefix string, prerunLevel zerolog.Level) CobraRunFun
}
}

func initOtlpTracer(exporter trace.SpanExporter, serviceName string) error {
func initOtelTracer(exporter trace.SpanExporter, serviceName string) error {
res, _ := resource.Merge(
resource.Default(),
resource.NewSchemaless(semconv.ServiceNameKey.String(serviceName)),
Expand Down

0 comments on commit f44ebf2

Please sign in to comment.