forked from mongodb/mongo-java-driver
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add top-level error labels to write concern error (mongodb#766)
This will allow the driver to properly retry writes that the server has labeled as a RetryableWriteError. JAVA-4244
- Loading branch information
Showing
5 changed files
with
483 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
205 changes: 205 additions & 0 deletions
205
...-core/src/test/resources/unified-test-format/retryable-writes/bulkWrite-serverErrors.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,205 @@ | ||
{ | ||
"description": "retryable-writes bulkWrite serverErrors", | ||
"schemaVersion": "1.0", | ||
"runOnRequirements": [ | ||
{ | ||
"minServerVersion": "3.6", | ||
"topologies": [ | ||
"replicaset" | ||
] | ||
} | ||
], | ||
"createEntities": [ | ||
{ | ||
"client": { | ||
"id": "client0", | ||
"useMultipleMongoses": false, | ||
"observeEvents": [ | ||
"commandStartedEvent" | ||
] | ||
} | ||
}, | ||
{ | ||
"database": { | ||
"id": "database0", | ||
"client": "client0", | ||
"databaseName": "retryable-writes-tests" | ||
} | ||
}, | ||
{ | ||
"collection": { | ||
"id": "collection0", | ||
"database": "database0", | ||
"collectionName": "coll" | ||
} | ||
} | ||
], | ||
"initialData": [ | ||
{ | ||
"collectionName": "coll", | ||
"databaseName": "retryable-writes-tests", | ||
"documents": [ | ||
{ | ||
"_id": 1, | ||
"x": 11 | ||
}, | ||
{ | ||
"_id": 2, | ||
"x": 22 | ||
} | ||
] | ||
} | ||
], | ||
"tests": [ | ||
{ | ||
"description": "BulkWrite succeeds after retryable writeConcernError in first batch", | ||
"runOnRequirements": [ | ||
{ | ||
"minServerVersion": "4.0", | ||
"topologies": [ | ||
"replicaset" | ||
] | ||
}, | ||
{ | ||
"minServerVersion": "4.1.7", | ||
"topologies": [ | ||
"sharded-replicaset" | ||
] | ||
} | ||
], | ||
"operations": [ | ||
{ | ||
"name": "failPoint", | ||
"object": "testRunner", | ||
"arguments": { | ||
"client": "client0", | ||
"failPoint": { | ||
"configureFailPoint": "failCommand", | ||
"mode": { | ||
"times": 1 | ||
}, | ||
"data": { | ||
"failCommands": [ | ||
"insert" | ||
], | ||
"errorLabels": [ | ||
"RetryableWriteError" | ||
], | ||
"writeConcernError": { | ||
"code": 91, | ||
"errmsg": "Replication is being shut down" | ||
} | ||
} | ||
} | ||
} | ||
}, | ||
{ | ||
"name": "bulkWrite", | ||
"object": "collection0", | ||
"arguments": { | ||
"requests": [ | ||
{ | ||
"insertOne": { | ||
"document": { | ||
"_id": 3, | ||
"x": 33 | ||
} | ||
} | ||
}, | ||
{ | ||
"deleteOne": { | ||
"filter": { | ||
"_id": 2 | ||
} | ||
} | ||
} | ||
] | ||
}, | ||
"expectResult": { | ||
"deletedCount": 1, | ||
"insertedCount": 1, | ||
"matchedCount": 0, | ||
"modifiedCount": 0, | ||
"upsertedCount": 0, | ||
"insertedIds": { | ||
"$$unsetOrMatches": { | ||
"0": 3 | ||
} | ||
}, | ||
"upsertedIds": {} | ||
} | ||
} | ||
], | ||
"expectEvents": [ | ||
{ | ||
"client": "client0", | ||
"events": [ | ||
{ | ||
"commandStartedEvent": { | ||
"command": { | ||
"insert": "coll", | ||
"documents": [ | ||
{ | ||
"_id": 3, | ||
"x": 33 | ||
} | ||
] | ||
}, | ||
"commandName": "insert", | ||
"databaseName": "retryable-writes-tests" | ||
} | ||
}, | ||
{ | ||
"commandStartedEvent": { | ||
"command": { | ||
"insert": "coll", | ||
"documents": [ | ||
{ | ||
"_id": 3, | ||
"x": 33 | ||
} | ||
] | ||
}, | ||
"commandName": "insert", | ||
"databaseName": "retryable-writes-tests" | ||
} | ||
}, | ||
{ | ||
"commandStartedEvent": { | ||
"command": { | ||
"delete": "coll", | ||
"deletes": [ | ||
{ | ||
"q": { | ||
"_id": 2 | ||
}, | ||
"limit": 1 | ||
} | ||
] | ||
}, | ||
"commandName": "delete", | ||
"databaseName": "retryable-writes-tests" | ||
} | ||
} | ||
] | ||
} | ||
], | ||
"outcome": [ | ||
{ | ||
"collectionName": "coll", | ||
"databaseName": "retryable-writes-tests", | ||
"documents": [ | ||
{ | ||
"_id": 1, | ||
"x": 11 | ||
}, | ||
{ | ||
"_id": 3, | ||
"x": 33 | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} |
173 changes: 173 additions & 0 deletions
173
...-core/src/test/resources/unified-test-format/retryable-writes/insertOne-serverErrors.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,173 @@ | ||
{ | ||
"description": "retryable-writes insertOne serverErrors", | ||
"schemaVersion": "1.0", | ||
"runOnRequirements": [ | ||
{ | ||
"minServerVersion": "3.6", | ||
"topologies": [ | ||
"replicaset" | ||
] | ||
} | ||
], | ||
"createEntities": [ | ||
{ | ||
"client": { | ||
"id": "client0", | ||
"useMultipleMongoses": false, | ||
"observeEvents": [ | ||
"commandStartedEvent" | ||
] | ||
} | ||
}, | ||
{ | ||
"database": { | ||
"id": "database0", | ||
"client": "client0", | ||
"databaseName": "retryable-writes-tests" | ||
} | ||
}, | ||
{ | ||
"collection": { | ||
"id": "collection0", | ||
"database": "database0", | ||
"collectionName": "coll" | ||
} | ||
} | ||
], | ||
"initialData": [ | ||
{ | ||
"collectionName": "coll", | ||
"databaseName": "retryable-writes-tests", | ||
"documents": [ | ||
{ | ||
"_id": 1, | ||
"x": 11 | ||
}, | ||
{ | ||
"_id": 2, | ||
"x": 22 | ||
} | ||
] | ||
} | ||
], | ||
"tests": [ | ||
{ | ||
"description": "InsertOne succeeds after retryable writeConcernError", | ||
"runOnRequirements": [ | ||
{ | ||
"minServerVersion": "4.0", | ||
"topologies": [ | ||
"replicaset" | ||
] | ||
}, | ||
{ | ||
"minServerVersion": "4.1.7", | ||
"topologies": [ | ||
"sharded-replicaset" | ||
] | ||
} | ||
], | ||
"operations": [ | ||
{ | ||
"name": "failPoint", | ||
"object": "testRunner", | ||
"arguments": { | ||
"client": "client0", | ||
"failPoint": { | ||
"configureFailPoint": "failCommand", | ||
"mode": { | ||
"times": 1 | ||
}, | ||
"data": { | ||
"failCommands": [ | ||
"insert" | ||
], | ||
"errorLabels": [ | ||
"RetryableWriteError" | ||
], | ||
"writeConcernError": { | ||
"code": 91, | ||
"errmsg": "Replication is being shut down" | ||
} | ||
} | ||
} | ||
} | ||
}, | ||
{ | ||
"name": "insertOne", | ||
"object": "collection0", | ||
"arguments": { | ||
"document": { | ||
"_id": 3, | ||
"x": 33 | ||
} | ||
}, | ||
"expectResult": { | ||
"$$unsetOrMatches": { | ||
"insertedId": { | ||
"$$unsetOrMatches": 3 | ||
} | ||
} | ||
} | ||
} | ||
], | ||
"expectEvents": [ | ||
{ | ||
"client": "client0", | ||
"events": [ | ||
{ | ||
"commandStartedEvent": { | ||
"command": { | ||
"insert": "coll", | ||
"documents": [ | ||
{ | ||
"_id": 3, | ||
"x": 33 | ||
} | ||
] | ||
}, | ||
"commandName": "insert", | ||
"databaseName": "retryable-writes-tests" | ||
} | ||
}, | ||
{ | ||
"commandStartedEvent": { | ||
"command": { | ||
"insert": "coll", | ||
"documents": [ | ||
{ | ||
"_id": 3, | ||
"x": 33 | ||
} | ||
] | ||
}, | ||
"commandName": "insert", | ||
"databaseName": "retryable-writes-tests" | ||
} | ||
} | ||
] | ||
} | ||
], | ||
"outcome": [ | ||
{ | ||
"collectionName": "coll", | ||
"databaseName": "retryable-writes-tests", | ||
"documents": [ | ||
{ | ||
"_id": 1, | ||
"x": 11 | ||
}, | ||
{ | ||
"_id": 2, | ||
"x": 22 | ||
}, | ||
{ | ||
"_id": 3, | ||
"x": 33 | ||
} | ||
] | ||
} | ||
] | ||
} | ||
] | ||
} |
Oops, something went wrong.