Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test improvements and cleanup #581

Merged
merged 4 commits into from Dec 30, 2023
Merged

Test improvements and cleanup #581

merged 4 commits into from Dec 30, 2023

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Dec 30, 2023 •
edited

Description

  • Helper method for reading keys in tests
  • Rename certs folter to keys
  • Removed keys not used in test
  • Read keys once from file into memory to speed up test execution
  • Added RSpec module reference where it was missing
  • Moved all the module spec files into the jwt subfolder to match the lib structure

Checklist

Before the PR can be merged be sure the following are checked:

  • There are tests for the fix or feature added/changed
  • A description of the changes and a reference to the PR has been added to CHANGELOG.md. More details in the CONTRIBUTING.md

@anakinj
Improvements for key handling in specs:
4bedddc 
- Helper method for reading keys in tests
- Rename certs folter to keys
- Removed keys not used in test
- Read keys once from file into memory to speed up test execution
@anakinj
Move all specs under the jwt folder
48cfdfa
@anakinj
Add missing RSpec module references to initial describe calls
ef4451a
@anakinj
Changelog entry
5392d1b
@anakinj anakinj merged commit 7c61cf4 into jwt:main Dec 30, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@anakinj