Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWK OKP Ed25519 support using rbnacl #540

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Dec 28, 2022

  • Support OPK JWKs, only Ed25519 for now
  • Requires the rbnacl gem
  • Prepare to deprecate the ::JWT::JWK::[RSA/EC/HMAC]#keypair method in favor of methods describing the use

Related to #394

 - Prepare to deprecate the ::JWT::JWK::[RSA/EC/HMAC]#keypair method in favor of methods describing the use
@cseeman
Copy link

cseeman commented Jan 20, 2023

Hey there @anakinj , any idea when this might merge? Would love to get that Ed25519 support in ruby-jwt so we can use that stronger cipher.

@timdawborn
Copy link

+1. Would love to see Ed25519 support in this library.

@anakinj
Copy link
Member Author

anakinj commented Jan 31, 2023

@cseeman and @timdawborn. Im thinking of merging this and cutting a new release. When I do, could you be so kind and provide some feedback on does it work "for real" everything so far is tested "in theory".

Also when the openssl gem supports these types better i think we could drop the rbnacl dependency.

@anakinj anakinj merged commit d6ee141 into jwt:main Jan 31, 2023
@cseeman
Copy link

cseeman commented Mar 16, 2023

Hey @anakinj just wanted to make sure that you got some feedback on this. It has been working in a prod system for a while with the new Ed25519 support, using JWK keys that are making using of this cipher. Thank you again for getting this merged in.

@anakinj
Copy link
Member Author

anakinj commented Mar 16, 2023

So appreciated that you took time to come back for the feedback. Great to hear it's valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants