-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a JWKS implementation #525
Conversation
This is a great idea. Left a few random comments |
The |
About the For example
|
The failing test is probably because ruby/openssl#538 has been shipped. Need to make the tests somehow pass on all versions. I'll take a look at this at some point in the near future, on a quick glimpse it looks great. |
@bellebaum I fixed the CI for Also a changelog entry would be great in regards to this feature addition. |
Great stuff. Big thank you for putting effort into this! |
This PR Draft implements JWK Sets (Part of RFC 7517) for easier handling of sets.
The goal was to make the handling of JWKS easier. E.g.
The draft allows for basic manipulation of the set:
export
ing to HashWhere possible, I tried to use function names and semantics common in the standard library, to not subvert user expectations.
There are currently no tests or documentation, but I would like to get some early feedback to incorporate :)
The selection of methods on JWKSs is currently based on stuff I find helpful in my projects, so feel free to request any changes.