New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support algorithm to be given as a class #512

Merged

anakinj merged 6 commits into jwt:main from anakinj:allow-algorithm-to-be-a-class

Oct 9, 2022

Member

anakinj commented Oct 1, 2022

This PR improves the algorithm handling on both encoding and decoding:

Support for passing custom algorithms to handle the signing and verification of tokens
When decoding the alg header is not used as anything else than a hint for the algorithm to try first from the allowed algorithms.

anakinj mentioned this pull request

Improved RSA signing and verification #494

Closed


          Support algorithm to be given as a class

6b50050

anakinj force-pushed the allow-algorithm-to-be-a-class branch from b8c52e2 to 6b50050 Compare

October 4, 2022 19:05

Member Author

anakinj commented Oct 4, 2022

Would you @excpt have time to check this out. Would enable some further improvements to be made to the signing and verification.

anakinj requested a review from excpt

October 4, 2022 19:14

MatteoPierro reviewed

View reviewed changes

lib/jwt/algos/algo_wrapper.rb Outdated Show resolved Hide resolved

MatteoPierro reviewed

View reviewed changes

lib/jwt/algos/algo_wrapper.rb Outdated Show resolved Hide resolved

MatteoPierro reviewed

View reviewed changes

spec/jwt_spec.rb Outdated Show resolved Hide resolved

MatteoPierro reviewed

View reviewed changes

spec/jwt_spec.rb Outdated Show resolved Hide resolved

MatteoPierro reviewed

View reviewed changes

spec/jwt_spec.rb Outdated Show resolved Hide resolved

anakinj added 3 commits

October 5, 2022 22:46


          Improve the tests for the custom algorithm logic

dcf1a3f


          Use att_readers for the AlgoWrapper

ed3ab24


          Simplifed algorithm matcher

704610a

anakinj requested a review from MatteoPierro

October 6, 2022 18:51

MatteoPierro approved these changes

View reviewed changes

Contributor

MatteoPierro left a comment

Looks great now 👍

anakinj removed the request for review from excpt

October 9, 2022 08:33

anakinj added 2 commits

October 9, 2022 11:59


          Require #valid_alg? to be implemented

4c8bf2d


          Readme and example of usage

752ec8b

anakinj force-pushed the allow-algorithm-to-be-a-class branch from 3ee0fa1 to 752ec8b Compare

October 9, 2022 11:35

anakinj merged commit 37a0d9e into jwt:main

nataliastanko mentioned this pull request

Bug: undefined method `casecmp' for nil:NilClass when invalid alg #558

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment