Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Time.now casting causing false positive in verify_at #393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinreedy
Copy link

Fixes #353

@sourcelevel-bot
Copy link

Hello, @kevinreedy! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@anakinj
Copy link
Member

anakinj commented Dec 21, 2020

Im wondering if the condition should be inclusive (>=) to handle cases where the verification happen on the same second the token has been issued.

Also a test verifying the "same-second" token would be good. Mocking the Time.now.to_i in a test could be a way to tackle the different cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issued At RFC type mismatch causing false postives on verify_at
2 participants