Enable rubocop locally and on ci #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SourceLevel has finished reviewing this Pull Request and has found:
|
anakinj
force-pushed
the
enable-rubocop
branch
from
99d7186
to
6f14ed7
Compare
anakinj
force-pushed
the
enable-rubocop
branch
from
6f14ed7
to
9b07e84
Compare
|
@excpt Im thinking of merging this to improve the local experience when developing the gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been struggling with sourcelevel-bot spamming PRs with comments about linting issues like extra whitespaces and such.
This PR adds the possibility to run rubocop locally to catch issues early in the process.
The version should be the same as Codeclimate is using(https://docs.codeclimate.com/docs/rubocop)