Make JWT::JWK::EC compatible with Ruby 2.3 #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakinj
force-pushed
the
fix-ec-for-23
branch
from
8f0527f
to
664673c
Compare
anakinj
force-pushed
the
fix-ec-for-23
branch
from
664673c
to
f75404d
Compare
|
SourceLevel has finished reviewing this Pull Request and has found:
|
|
@richardlarocque Are you OK with these changes. Unfortunately think we need to support the EOL rubies as long as the gemspec claims we do. Hoping to drop support for the oldies soon |
anakinj
changed the title
|
I'll go on and merge this to get the tests green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that the
OpenSSL::PKey::EC#generate_key!method is not available in Ruby 2.3 without installing the openssl gem.This other PR that is making the CIactually test the supported Rubies and combinations revealed that:
https://travis-ci.org/github/jwt/ruby-jwt/jobs/747060754