Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle parsed JSON JWKS input with string keys #348

Merged
merged 5 commits into from Sep 1, 2020
Merged

Handle parsed JSON JWKS input with string keys #348

merged 5 commits into from Sep 1, 2020
+97 −16

Commits on Jul 7, 2020

  1. Add specs to show that parsed JSON doesn't work

    @martinemde
    martinemde committed Jul 7, 2020
    Copy the full SHA
    16d85af View commit details
    Browse the repository at this point in the history

  2. JWK loading of string keys from parsed JSON 

    This fixes an issue where JSON.parse results of an actual .jwks file
fail to import into the key finder because they have string keys.

Errors also improved in a way that helps debugging issues with JWKS loading.
    @martinemde
    martinemde committed Jul 7, 2020
    Copy the full SHA
    b4d6f8b View commit details
    Browse the repository at this point in the history

  3. single quoted strings

    @martinemde
    martinemde committed Jul 7, 2020
    Copy the full SHA
    98e183e View commit details
    Browse the repository at this point in the history

  4. Offer a sacrifice to the code climate gods

    @martinemde
    martinemde committed Jul 7, 2020
    Copy the full SHA
    1549595 View commit details
    Browse the repository at this point in the history

  5. Does this make code climate happy?

    @martinemde
    martinemde committed Jul 7, 2020
    Copy the full SHA
    549df84 View commit details
    Browse the repository at this point in the history