Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older versions not discoverable. #21

Closed
henryiii opened this issue Jan 18, 2021 · 13 comments
Closed

Older versions not discoverable. #21

henryiii opened this issue Jan 18, 2021 · 13 comments

Comments

@henryiii
Copy link
Contributor

henryiii commented Jan 18, 2021

Older versions of CMake are reporting that they are not found. 3.4-3.8 are not working, while 3.18 is fine. Broken on both 1.5 and 1.6; it used to be working so maybe the API this is using changed the way it reports?

I think loading multiple pages is broken, only releases on page 1 are now accessible, perhaps? I don't see anything different here, and by hand it seems to be fine.

See pybind/pybind11#2805.

@henryiii
Copy link
Contributor Author

henryiii commented Jan 18, 2021

@Holzhaus
Copy link

I see the same on 3.13.x:

Run jwlawson/actions-setup-cmake@v1.4
Error: Unable to find version matching 3.13.x

https://github.com/mixxxdj/mixxx/runs/1724308441

I didn't touch the CI config and I'm sure this worked yesterday.

@archurcode
Copy link

the same on 3.10.2:
Unable to find version matching 3.10.2

@alkino
Copy link

alkino commented Jan 19, 2021

I think the github API is broken.
There is no more Link: header. So the module cannot guess there is new pages to look for.

@alkino
Copy link

alkino commented Jan 19, 2021

@henryiii
Copy link
Contributor Author

Sorry, I've been debugging in the linked PR, should have been posting here I guess.

@jwlawson
Copy link
Owner

I've managed to have a quick look into this. It does seem that something weird is going on with the GitHub API.

Trying Octokit gives the same failures, as it seems to also use the Link header for pagination.

Manually going back through the release JSON pages, I can only see results up to https://api.github.com/repos/kitware/cmake/releases?page=5 (with 3.12.4 as the last visible release). Then https://api.github.com/repos/kitware/cmake/releases?page=6 returns no results, even though https://github.com/Kitware/CMake/releases?after=v3.12.4 still shows the old releases. So even iterating through the pages like that won't work currently.

@henryiii
Copy link
Contributor Author

I don't think they are ordered by number, but by date. I'm pretty sure the older releases were on page 4 or 5, there are just also newer releases too. Can check later.

@henryiii
Copy link
Contributor Author

I see at least 3.7 on page 4. When they started the mirror, all the early releases got added at the same time. So I think pagination is fine, just that header is missing.

@henryiii
Copy link
Contributor Author

henryiii commented Jan 19, 2021

This is the current list of versions if you just load the first 5 pages, in the order they are presented:

Page 1: v3.19.3 v3.19.2 v3.19.1 v3.19.0 v3.18.5 v3.19.0-rc3 v3.19.0-rc2 v3.19.0-rc1 v3.18.4 v3.18.3 v3.17.5 v3.16.9 v3.18.2 v3.18.1 v3.17.4 v3.18.0 v3.18.0-rc4 v3.18.0-rc3 v3.18.0-rc2 v3.18.0-rc1 v3.16.8 v3.17.3 v3.16.7 v3.17.2 v3.16.6 v3.17.1 v3.17.0 v3.17.0-rc3 v3.16.5 v3.17.0-rc2
Page 2: v3.17.0-rc1 v3.16.4 v3.15.7 v3.16.3 v3.16.2 v3.15.6 v3.16.1 v3.16.0 v3.16.0-rc4 v3.16.0-rc3 v3.15.5 v3.16.0-rc2 v3.16.0-rc1 v3.14.7 v3.15.4 v3.15.3 v3.15.2 v3.15.1 v3.15.0 v3.14.6 v3.15.0-rc4 v3.15.0-rc3 v3.15.0-rc2 v3.15.0-rc1 v3.14.5 v3.14.4 v3.13.5 v3.14.3 v3.14.2 v3.14.1
Page 3: v3.14.0 v3.14.0-rc4 v3.14.0-rc3 v3.14.0-rc2 v3.14.0-rc1 v3.13.4 v3.13.3 v3.13.2 v2.4.8 v2.6.4 v2.8.12.2 v2.8.10.2 v3.0.0 v3.0.1 v3.0.2 v3.1.0 v3.1.1 v3.1.2 v3.1.3 v3.2.0 v3.2.1 v3.2.2 v3.2.3 v3.3.0 v3.3.2 v3.4.1 v3.4.2 v3.6.2 v3.6.3 v3.7.0
Page 4: v3.9.1 v3.9.2 v3.9.3 v3.9.5 v3.3.1 v3.4.0 v3.4.3 v3.5.0 v3.5.1 v3.5.2 v3.6.0 v3.6.1 v3.7.1 v3.7.2 v3.8.0 v3.8.1 v3.8.2 v3.9.0 v3.9.4 v3.9.6 v3.10.0 v3.10.1 v3.10.2 v3.10.3 v3.11.0 v3.11.1 v3.11.2 v3.11.3 v3.11.4 v3.12.0
Page 5: v3.12.1 v3.12.2 v3.12.3 v3.13.1 v3.13.0 v3.12.4

So they are all there, I think. It's 126 releases, so must be less than 100 per page.

The initial sync with GitHub must have happened right before v3.13.2.

@jwlawson
Copy link
Owner

Oh right. Thanks. I made some changes to just iterate through the pages in #23 without relying on the Link header.

@lewri
Copy link

lewri commented Jan 19, 2021

Just passing note -- appears this is working now for CMake 3.5 in our gh-actions for CorsixTH

@henryiii
Copy link
Contributor Author

Solved by GitHub in 1-2 days, pagination works again. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants