New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Older versions not discoverable. #21
Comments
https://api.github.com/repos/Kitware/cmake/releases works and https://api.github.com/repos/Kitware/cmake/releases?page=1 does too. Not sure why this might be broken. |
I see the same on 3.13.x:
https://github.com/mixxxdj/mixxx/runs/1724308441 I didn't touch the CI config and I'm sure this worked yesterday. |
the same on 3.10.2: |
I think the github API is broken. |
In fact @henryiii already report it: https://github.community/t/bug-rest-api-for-releases-missing-link/156320 |
Sorry, I've been debugging in the linked PR, should have been posting here I guess. |
I've managed to have a quick look into this. It does seem that something weird is going on with the GitHub API. Trying Octokit gives the same failures, as it seems to also use the Link header for pagination. Manually going back through the release JSON pages, I can only see results up to https://api.github.com/repos/kitware/cmake/releases?page=5 (with 3.12.4 as the last visible release). Then https://api.github.com/repos/kitware/cmake/releases?page=6 returns no results, even though https://github.com/Kitware/CMake/releases?after=v3.12.4 still shows the old releases. So even iterating through the pages like that won't work currently. |
I don't think they are ordered by number, but by date. I'm pretty sure the older releases were on page 4 or 5, there are just also newer releases too. Can check later. |
I see at least 3.7 on page 4. When they started the mirror, all the early releases got added at the same time. So I think pagination is fine, just that header is missing. |
This is the current list of versions if you just load the first 5 pages, in the order they are presented: Page 1: v3.19.3 v3.19.2 v3.19.1 v3.19.0 v3.18.5 v3.19.0-rc3 v3.19.0-rc2 v3.19.0-rc1 v3.18.4 v3.18.3 v3.17.5 v3.16.9 v3.18.2 v3.18.1 v3.17.4 v3.18.0 v3.18.0-rc4 v3.18.0-rc3 v3.18.0-rc2 v3.18.0-rc1 v3.16.8 v3.17.3 v3.16.7 v3.17.2 v3.16.6 v3.17.1 v3.17.0 v3.17.0-rc3 v3.16.5 v3.17.0-rc2 So they are all there, I think. It's 126 releases, so must be less than 100 per page. The initial sync with GitHub must have happened right before v3.13.2. |
Oh right. Thanks. I made some changes to just iterate through the pages in #23 without relying on the Link header. |
Just passing note -- appears this is working now for CMake 3.5 in our gh-actions for CorsixTH |
Solved by GitHub in 1-2 days, pagination works again. 🎉 |
Older versions of CMake are reporting that they are not found. 3.4-3.8 are not working, while 3.18 is fine. Broken on both 1.5 and 1.6; it used to be working so maybe the API this is using changed the way it reports?
I think loading multiple pages is broken, only releases on page 1 are now accessible, perhaps? I don't see anything different here, and by hand it seems to be fine.
See pybind/pybind11#2805.
The text was updated successfully, but these errors were encountered: