Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] afterLoad for emergencies with undiscovered diseases #1804

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

lewri
Copy link
Member

@lewri lewri commented Jan 18, 2021

Complementary PR to #1754 to allow for emergencies that slip through the net from old saves to be course-corrected.
For clarity, I tracked down the savegame version that 1754 sat on and adjusted the afterload's old number as necessary.

Closes #1799

Describe what the proposed change does

  • Afterload added for emergencies of undiscovered diseases in old saves that are active to prevent the casebook bug fixed by 1754
  • In above case, the disease is automatically discovered to prevent crashing (too late to try and cancel the emergency now!)

Complementary PR to CorsixTH#1754 to allow for emergencies that slip through the net from old saves to be course-corrected.
@lewri
Copy link
Member Author

lewri commented Jan 19, 2021

Aware of why this one's failing caused upstream: jwlawson/actions-setup-cmake/issues/21

Edit: Fixed now

@TheCycoONE
Copy link
Member

In the mean time could you bump the savegame number?

@lewri
Copy link
Member Author

lewri commented Jan 19, 2021

Savegame version on master is currently 151 , I'm cautious as this is an afterload for an older PR, it could cause breakage by having a savegame version out of sync with the time #1754 was merged (that version was 149).
Happy to bump the afterLoad and version to 152 if necessary though.

@lewri
Copy link
Member Author

lewri commented Jan 19, 2021

Have bumped it now, realising the afterload of this PR isn't actually that drastic 😄

@TheCycoONE TheCycoONE merged commit 361b7fa into CorsixTH:master Jan 22, 2021
tobylane added a commit to tobylane/CorsixTH that referenced this pull request Feb 4, 2021
@lewri lewri deleted the afterLoad-4-1754 branch April 19, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Opening Case Book via patient window when disease has not yet been discovered softlocks game
2 participants