fix: Save developer note changes to g.xlf

jwikman · Feb 24, 2024 · 65a67d9 · 65a67d9
1 parent f8f07dc
commit 65a67d9
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/extension/src/Xliff/XLIFFDocument.ts b/extension/src/Xliff/XLIFFDocument.ts
@@ -42,6 +42,7 @@ export class Xliff implements XliffDocumentInterface {
   public buildNum?: string;
   public requestId?: string;
   public header?: HeaderInterface;
+  public _isModified = false;
 
   constructor(
     datatype: string,

diff --git a/extension/src/XliffFunctions.ts b/extension/src/XliffFunctions.ts
@@ -211,6 +211,9 @@ export async function _refreshXlfFilesFromGXlf({
       languageFunctionsSettings.searchReplaceBeforeSaveXliff
     );
   }
+  if (gXliff._isModified) {
+    gXliff.toFileSync(gXliff._path, undefined, true, []);
+  }
 
   return refreshResult;
 }
@@ -303,9 +306,13 @@ export function refreshSelectedXlfFileFromGXlf(
         if (threeLetterAbbreviationLanguageCode) {
           targetFoundInComments = addTranslationIfFound(
             langTransUnit,
+            gTransUnit,
             threeLetterAbbreviationLanguageCode,
             transUnitsToRemoveCommentsInCode
           );
+          if (targetFoundInComments) {
+            gXliff._isModified = true;
+          }
         }
         if (
           !targetFoundInComments &&
@@ -348,9 +355,13 @@ export function refreshSelectedXlfFileFromGXlf(
       if (threeLetterAbbreviationLanguageCode) {
         targetFoundInComments = addTranslationIfFound(
           newTransUnit,
+          gTransUnit,
           threeLetterAbbreviationLanguageCode,
           transUnitsToRemoveCommentsInCode
         );
+        if (targetFoundInComments) {
+          gXliff._isModified = true;
+        }
       }
       if (!targetFoundInComments) {
         newTransUnit.targets.push(
@@ -422,6 +433,7 @@ export function refreshSelectedXlfFileFromGXlf(
 
   function addTranslationIfFound(
     langTransUnit: TransUnit,
+    gTransUnit: TransUnit,
     threeLetterAbbreviationLanguageCode: string,
     transUnitsToRemoveCommentsInCode: Map<TransUnit, string>
   ): boolean {
@@ -439,6 +451,12 @@ export function refreshSelectedXlfFileFromGXlf(
           .developerNote()
           .textContent.replace(matchResult[0], "");
         transUnitsToRemoveCommentsInCode.set(langTransUnit, matchResult[0]);
+        if (
+          gTransUnit.developerNote().textContent !==
+          langTransUnit.developerNote().textContent
+        ) {
+          gTransUnit.developerNote().textContent = langTransUnit.developerNote().textContent;
+        }
       }
       return true;
     }