Skip to content

Commit

Permalink
rebase fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ss89 committed Feb 10, 2021
1 parent 688f6da commit d0d6a58
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
2 changes: 1 addition & 1 deletion pkg/cfg/options_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (s *OptionsTestSuite) TestWithConfigSetting() {

actual = s.config.Get("a")
expectedMsi = expected.Msi()
s.Equal(expected.Msi(), actual)
s.Equal(expectedMsi, actual)
}

func TestOptionsTestSuite(t *testing.T) {
Expand Down
14 changes: 1 addition & 13 deletions pkg/stream/mpr_metric_module.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,6 @@ const (
metricNameStreamMprMessagesPerRunner = "StreamMprMessagesPerRunner"
)

type mprMetricPerConsumer map[string]float64

func (d mprMetricPerConsumer) Sum() float64 {
sum := 0.0

for _, v := range d {
sum += v
}

return sum
}

type MessagesPerRunnerMetricWriterSettings struct {
ConsumerSpecs []*ConsumerSpec
UpdatePeriod time.Duration
Expand All @@ -48,7 +36,7 @@ func MessagesPerRunnerMetricWriterFactory(config cfg.Config, logger mon.Logger)
return modules, nil
}

moduleName := fmt.Sprintf("stream-metric-messages-per-runner")
moduleName := "stream-metric-messages-per-runner"
modules[moduleName] = NewMessagesPerRunnerMetricWriter(settings)

return modules, nil
Expand Down

0 comments on commit d0d6a58

Please sign in to comment.