-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pie-modal): Add modal component shell #439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d474251 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
webbertakken
previously approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
ashleynolan
reviewed
May 11, 2023
fernandofranca
force-pushed
the
modal-component-shell
branch
from
May 11, 2023 09:35
29b0baf
to
3c4fde1
Compare
fernandofranca
requested review from
ashleynolan,
sebastienrocks and
webbertakken
May 11, 2023 09:36
jamieomaguire
previously approved these changes
May 11, 2023
raoufswe
reviewed
May 11, 2023
raoufswe
reviewed
May 11, 2023
fernandofranca
force-pushed
the
modal-component-shell
branch
2 times, most recently
from
May 11, 2023 10:48
687da28
to
85b3577
Compare
webbertakken
previously approved these changes
May 11, 2023
fernandofranca
force-pushed
the
modal-component-shell
branch
2 times, most recently
from
May 12, 2023 07:38
5477e3e
to
c50afb7
Compare
fernandofranca
force-pushed
the
modal-component-shell
branch
2 times, most recently
from
May 12, 2023 07:41
10f17fb
to
a3e29db
Compare
fernandofranca
force-pushed
the
modal-component-shell
branch
from
May 12, 2023 08:01
a3e29db
to
2eabcdb
Compare
raoufswe
approved these changes
May 12, 2023
xander-marjoram
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes (can list changeset entries if preferable)
pie-modal
[Added] - PieModal component shell
[Added] - README and LICENSE files
[Added] - Initial TypeScript and Vite config
[Added] -
declaration.d.ts
file for TypeScriptpie-button
[Changed] - Added missing newline at the end of tsconfig.json
[Changed] - Updated README.md
[Removed] - Removed npm
dev
scriptpie-monorepo
[Changed] - Updated github labeler