Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pie-modal): Add modal component shell #439

Merged
merged 10 commits into from
May 12, 2023
Merged

Conversation

fernandofranca
Copy link
Contributor

@fernandofranca fernandofranca commented May 10, 2023

Describe your changes (can list changeset entries if preferable)

pie-modal

[Added] - PieModal component shell
[Added] - README and LICENSE files
[Added] - Initial TypeScript and Vite config
[Added] - declaration.d.ts file for TypeScript

pie-button

[Changed] - Added missing newline at the end of tsconfig.json
[Changed] - Updated README.md
[Removed] - Removed npm dev script

pie-monorepo

[Changed] - Updated github labeler

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023

🦋 Changeset detected

Latest commit: d474251

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-439 May 10, 2023 12:31 Inactive
@github-actions github-actions bot temporarily deployed to pie-docs-pr-439 May 10, 2023 12:32 Inactive
webbertakken
webbertakken previously approved these changes May 10, 2023
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

packages/components/pie-modal/README.md Outdated Show resolved Hide resolved
packages/components/pie-modal/tsconfig.json Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-439 May 11, 2023 09:41 Inactive
jamieomaguire
jamieomaguire previously approved these changes May 11, 2023
@github-actions github-actions bot temporarily deployed to pie-docs-pr-439 May 11, 2023 09:41 Inactive
@fernandofranca fernandofranca force-pushed the modal-component-shell branch 2 times, most recently from 687da28 to 85b3577 Compare May 11, 2023 10:48
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-439 May 11, 2023 10:55 Inactive
@github-actions github-actions bot temporarily deployed to pie-docs-pr-439 May 11, 2023 10:55 Inactive
webbertakken
webbertakken previously approved these changes May 11, 2023
@fernandofranca fernandofranca force-pushed the modal-component-shell branch 2 times, most recently from 10f17fb to a3e29db Compare May 12, 2023 07:41
@github-actions github-actions bot temporarily deployed to pie-docs-pr-439 May 12, 2023 07:47 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-439 May 12, 2023 07:47 Inactive
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-439 May 12, 2023 08:06 Inactive
@github-actions github-actions bot temporarily deployed to pie-docs-pr-439 May 12, 2023 08:07 Inactive
@fernandofranca fernandofranca merged commit 457d604 into main May 12, 2023
21 of 22 checks passed
@fernandofranca fernandofranca deleted the modal-component-shell branch May 12, 2023 12:46
This was referenced May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants