Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pie@v1.10.0 - move some pie microsite dev dependencies to root level package.json #21

Merged
merged 3 commits into from
Sep 2, 2022
Merged

pie@v1.10.0 - move some pie microsite dev dependencies to root level package.json #21

merged 3 commits into from
Sep 2, 2022

Conversation

jamieomaguire
Copy link
Contributor

@jamieomaguire jamieomaguire commented Sep 2, 2022 •
edited

v1.10.0

September 2, 2022

Added

  • Moved most dev dependencies from pie-microsite into root level depedencies
  • Dependency resolution fix to .yarnrc.yml for stylelint-config-recommended-scss and stylelint-config-standard-scss as recommended in this github issues thread

kevinrodrigues
kevinrodrigues previously approved these changes Sep 2, 2022
View reviewed changes
DamianMullins
DamianMullins previously approved these changes Sep 2, 2022
View reviewed changes
ashleynolan
ashleynolan reviewed Sep 2, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
ashleynolan
ashleynolan requested changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@ashleynolan ashleynolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment on version range – otherwise LGTM

@jamieomaguire jamieomaguire changed the title pie@v1.10.0 - move fozzie and pie icons to root level package.json pie@v1.10.0 - move some dev dependencies to root level package.json from pie microsite Sep 2, 2022
@jamieomaguire jamieomaguire changed the title pie@v1.10.0 - move some dev dependencies to root level package.json from pie microsite pie@v1.10.0 - move some pie microsite dev dependencies to root level package.json Sep 2, 2022
@jamieomaguire jamieomaguire requested review from ashleynolan and removed request for ashleynolan September 2, 2022 13:14
@ashleynolan ashleynolan merged commit cf661f0 into main Sep 2, 2022
@ashleynolan ashleynolan deleted the update-fozzie branch September 2, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleynolan ashleynolan ashleynolan approved these changes

@kevinrodrigues kevinrodrigues kevinrodrigues approved these changes

@siggerzz siggerzz siggerzz approved these changes

@DamianMullins DamianMullins Awaiting requested review from DamianMullins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jamieomaguire @DamianMullins @ashleynolan @kevinrodrigues @siggerzz