fozzie-components@v7.0.0 – Switch to dart-sass #globalconfig #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
atoms
kevinrodrigues
commented
Feb 8, 2022
kevinrodrigues
changed the title
ashleynolan
force-pushed
the
dart-sass-upgrade4
branch
from
e14e867
to
498a238
Compare
github-actions
bot
added
organisms
ashleynolan
force-pushed
the
dart-sass-upgrade4
branch
from
032d5f8
to
55e706f
Compare
ashleynolan
changed the title
ashleynolan
force-pushed
the
dart-sass-upgrade4
branch
from
76388b9
to
ce30e88
Compare
ashleynolan
reviewed
Feb 15, 2022
dandel10n
reviewed
Feb 15, 2022
oliversweb
approved these changes
Feb 15, 2022
DamianMullins
approved these changes
Feb 15, 2022
kevinrodrigues
commented
Feb 16, 2022
There was a problem hiding this comment.
Thanks alot for picking this up whilst I was away @ashleynolan 🎖️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
dart-sassinstead ofnode-sassfor styles.There is still an outstanding issue in
vue-jestand it's support of dart-sass which means for componentswanting to compile styles in jest (to test classnames for instance),
node-sassstill needs to be includedas part of that packages
devDepenedencies. For all other packages,experimentalCSSCompile: falsehas beenset to turn off jest compiling styles, otherwise the tests won't run as expected.
sass-loader's node_modules path resolution, as this comes out of the box.Removed
$themevariables incommon.scssfiles, as no longer needed.~for fozzie scss refrences, as not needed – sass-loader does this automatically now.