Dark highlighting #463
Dark highlighting #463
Conversation
Move highlighting colours from `code.scss` to `light.scss`. Add GitHub Dark hihlighting colurs to `dark.scss`. Test using `Preview dark...` button in Configuration page.
- Add copies of CSS files from Pygments - Replace GitHub Dark colours in _sass/color_schemes/dark.scss by an import
|
Looks good but I don't think all of the 200 style files are needed |
I'll be happy to remove some/most of them, but I'm not sure which to keep – users may have custom color schemes, and prefer different highlighting themes. |
Correct the dark code highlighting: - Change the extension of the imported CSS file to `scss`. - Remove unused `pygments` folders and files. Dark code highlighting tested with Jekyll 3.8.7 and 4.1.1.
|
The above update changes the extension of the imported CSS file for dark code highlighting from |
- Useful for local testing when using Jekyll >= 4.2
- Allow bundler >= 2.1.4
- Add dark mode preview button
- Remove color setting for h5 and h6 It was overriding the setting in base.scss, and unsuitable for dark color schemes.
|
The color setting for |
| @@ -0,0 +1,5 @@ | |||
| # For local development and testing, use the option | |||
There was a problem hiding this comment.
I would remove this file as it does not contain any non-default setting.
There was a problem hiding this comment.
Thanks for the review! I agree that this file should be removed – especially as a change in Jekyll v4 makes it useless.
This PR is included in #578, which @mattxwang is currently reviewing for possible inclusion in v0.4.0; if it is included, this PR will be closed, so I'm inclined to wait with updates until that has been decided.
| spec.add_development_dependency "bundler", "~> 2.1.4" | ||
| spec.add_development_dependency "bundler", ">= 2.1.4" |
There was a problem hiding this comment.
i think, this should go into s seperate PR
There was a problem hiding this comment.
I agree. @mattxwang is adjusting the gem spec for v0.4.0.
| @@ -0,0 +1,858 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Yes; the docs could provide a link to https://pygments.org. I should do this also in #578 when it that PR has been reviewed.
This PR combines (and resolves conflicts between) #448, #463, #466, #494, #495, #496, #498, and #572. The main aim is to facilitate use of several of the implemented features _together_, when using the fork as a remote theme. It should also simplify merging the included PRs into a future release. The branch [combination-rec-nav](https://github.com/pdmosses/just-the-docs/tree/combination-rec-nav) adds [multi-level navigation](#462) and (NEW:) [sibling links](#394) to the branch used for this PR. It includes updated [documentation for the navigation structure](https://pdmosses.github.io/just-the-docs/docs/navigation-structure/), and reorganised and extended [navigation tests](https://pdmosses.github.io/just-the-docs/tests/navigation/). The documentation and the tests can be browsed at the (temporary) [website published from the combination-rec-nav branch](https://pdmosses.github.io/just-the-docs/). _Caveat:_ The changes to v0.3.3 in this PR and #462 have not yet been reviewed or approved, and may need updating before merging into a release of the theme. If you use a branch from a PR as a remote theme, there is a risk of such updates affecting your website. Moreover, these branches are likely to be deleted after they have been merged. To avoid such problems, you could copy the branch that you want to use to your own fork of the theme. Co-authored-by: Matt Wang <matt@matthewwang.me>
Fix #374 using a Pygments highlighting theme suggested by @MrBartusek, producing:
Copies of alternative Pygments files are included, to make it easy for users to change.