Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update session and kernel manager data only if there was a real change. #9189

Merged
merged 3 commits into from Oct 22, 2020
Merged

Update session and kernel manager data only if there was a real change. #9189

merged 3 commits into from Oct 22, 2020

Commits on Oct 20, 2020

  1. Only check session attributes we care about when determining if we ne… 

    …ed to update.

This was accidentally comparing extra information the server gives us, and in particular the last activity time was *always* forcing an update. Instead, we just check relevant attributes to determine if we need to update.

Fixes jupyterlab#9133
    @jasongrout
    jasongrout committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    edd04f7 View commit details
    Browse the repository at this point in the history

  2. Check only kernel model attributes we are tracking to see if an updat… 

    …e is needed.

This solves the same problem as the previous commit, but for kernels.
    @jasongrout
    jasongrout committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    848d54d View commit details
    Browse the repository at this point in the history

  3. integrity

    @jasongrout
    jasongrout committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    73fe6ef View commit details
    Browse the repository at this point in the history