Remove CTRL+SHIFT+Q shortcut for "Close and Shut Down [Notebook]" #16331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
JasonWeill
force-pushed
the
ctrl-shift-q-remove
branch
from
830ee0e
to
4cd6b58
Compare
|
please update snapshots |
|
Documentation snapshots updated. |
|
Galata snapshots updated. |
|
I think we need to finish #14015 so that users can add it the shortcut back from the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #16330.
Code changes
Removes the CTRL+SHIFT+Q keybinding for "Close and Shut Down [Notebook]", which either did not work or caused the user's entire browser to quit, particularly on Windows, where CTRL is a common accelerator key for browser commands in our supported browsers.
User-facing changes
Users will no longer be able to trigger a command with CTRL+SHIFT+Q, even in browsers and on OSes where this previously worked.
Backwards-incompatible changes
No public API changes.