-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Python tests on MacOS with Python 12, replace canvas
with jest-canvas-mock
#16314
Conversation
Thanks for making a pull request to jupyterlab! |
canvas
with jest-canvas-mock
It looks like vega5 needs it to. Should we just add it to @jupyterlab/testing package or is there value in only having this in individual packages? |
@ericsnekbytes you may want to try out this branch - it is passing on CI already |
@krassowski Just built this locally and it worked :) Thanks for your work on this! |
Great! Can you tick the "Approve" on GitHub review just so that it does not show up as unreviewed later? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested this locally.
References
canvas
withjest-canvas-mock
to fix Error during build steps on macos #16311 by getting rid of the compilation requirementCode changes
None
User-facing changes
None
Backwards-incompatible changes
None