Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in workspace format documentation (4.1.x) #16305

Merged
merged 1 commit into from
May 8, 2024

Conversation

jerrison
Copy link

@jerrison jerrison commented May 8, 2024

Fixing typo.

References

Code changes

User-facing changes

Backwards-incompatible changes

Fixed typo.
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link

welcome bot commented May 8, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski krassowski added this to the 4.2.x milestone May 8, 2024
@krassowski krassowski changed the title Update urls.rst Fix typo in workspace format documentation (4.1.x) May 8, 2024
@krassowski krassowski modified the milestones: 4.2.x, 4.1.x May 8, 2024
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -207,7 +207,7 @@ default workspace.
Workspace File Format
---------------------

A workspace file in a JSON file with a specific spec.
A workspace file is a JSON file with a specific spec.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of note this is fixed on 4.2.x and rewritten to: "A workspace file is a JSON file that contains one object with two required top-level keys, data, and metadata."

@krassowski krassowski merged commit 7d1b885 into jupyterlab:4.1.x May 8, 2024
79 of 82 checks passed
Copy link

welcome bot commented May 8, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@jerrison jerrison deleted the patch-1 branch May 11, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants