Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to invoke inline completer anywhere (not only at the end of line) #16298

Merged
merged 1 commit into from
May 8, 2024

Conversation

ajbozarth
Copy link
Contributor

References

Fixes #16295

Code changes

The inline completer prevents automatic running of the completer when not at the end of a line of code, but it is also applying this when invoked manually, which was unintended. This addresses that bug.

User-facing changes

Allows a user to manually invoke the inline completer anywhere in their code

The inline completer prevents aitomatic running of the completer
when not at the end of a line of code, but it is also applying this
when invoked manually, which was unintended. This addresses that bug.

Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth requested a review from krassowski May 7, 2024 00:29
@ajbozarth ajbozarth self-assigned this May 7, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@ajbozarth ajbozarth added the bug label May 7, 2024
@krassowski krassowski added this to the 4.1.x milestone May 7, 2024
@krassowski krassowski changed the title Inline completer should run anywhere when invoked Allow to inline completer anywhere, not only at end of line May 7, 2024
@krassowski krassowski changed the title Allow to inline completer anywhere, not only at end of line Allow to invoke inline completer anywhere (not only at the end of line) May 7, 2024
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ajbozarth!

@krassowski krassowski merged commit a5f9207 into jupyterlab:main May 8, 2024
83 of 85 checks passed
@krassowski
Copy link
Member

@meeseeksdev please backport to 4.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request May 8, 2024
krassowski pushed a commit that referenced this pull request May 8, 2024
…ly at the end of line) (#16307)

Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
@ajbozarth ajbozarth deleted the inline branch May 8, 2024 13:42
@ajbozarth
Copy link
Contributor Author

@meeseeksdev please backport to 4.2.x

Copy link

lumberbot-app bot commented May 29, 2024

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@ajbozarth
Copy link
Contributor Author

@krassowski I noticed 4.2.1 went out last week and this wasn't in it. I believe this was missed when creating the 4.2.x branch prior to moving main to 3.0.x, how should we address this?

@fcollonval
Copy link
Member

Hey @ajbozarth I see the commit on the branch 4.2.x: https://github.com/jupyterlab/jupyterlab/commits/4.2.x/

But indeed it is not listing in the changelog (releaser bug?). Could you check it is fixed in 4.2.1?

@ajbozarth
Copy link
Contributor Author

Ah sorry, I only checked the changelog. It is there, thanks :)

@fcollonval
Copy link
Member

Thanks for quickly checking, we need to update the changelog I guess.

@fcollonval fcollonval mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InlineCompleter only runs when cursor is at the end of a line
3 participants