-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to invoke inline completer anywhere (not only at the end of line) #16298
Conversation
The inline completer prevents aitomatic running of the completer when not at the end of a line of code, but it is also applying this when invoked manually, which was unintended. This addresses that bug. Signed-off-by: Alex Bozarth <ajbozart@us.ibm.com>
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ajbozarth!
@meeseeksdev please backport to 4.1.x |
…re (not only at the end of line)
…ly at the end of line) (#16307) Co-authored-by: Alex Bozarth <ajbozart@us.ibm.com>
@meeseeksdev please backport to 4.2.x |
Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out. |
@krassowski I noticed 4.2.1 went out last week and this wasn't in it. I believe this was missed when creating the 4.2.x branch prior to moving main to 3.0.x, how should we address this? |
Hey @ajbozarth I see the commit on the branch 4.2.x: https://github.com/jupyterlab/jupyterlab/commits/4.2.x/ But indeed it is not listing in the changelog (releaser bug?). Could you check it is fixed in 4.2.1? |
Ah sorry, I only checked the changelog. It is there, thanks :) |
Thanks for quickly checking, we need to update the changelog I guess. |
References
Fixes #16295
Code changes
The inline completer prevents automatic running of the completer when not at the end of a line of code, but it is also applying this when invoked manually, which was unintended. This addresses that bug.
User-facing changes
Allows a user to manually invoke the inline completer anywhere in their code